Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: test/webkit/enter-dictionary-indexing-mode-with-blank-indexing-type.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/webkit/enter-dictionary-indexing-mode-with-blank-indexing-type.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/enter-dictionary-indexing-mode-with-blank-indexing-type.js
similarity index 82%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/enter-dictionary-indexing-mode-with-blank-indexing-type.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..4a95d84ab9ed66df01fc888a63afc872b2bff62a 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/enter-dictionary-indexing-mode-with-blank-indexing-type.js
@@ -22,10 +22,10 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Tests that putting an object into dictionary mode when it has a blank indexing type doesn't cause us to crash."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
-
+// Freezing the Array prototype causes us to create ArrayStorage on the prototype, which has a blank indexing type.
+Object.freeze(Array.prototype);
+shouldBe("Object.isFrozen(Array.prototype)", "true");

Powered by Google App Engine
This is Rietveld 408576698