Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: test/webkit/sort-with-side-effecting-comparisons.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/webkit/sort-with-side-effecting-comparisons.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/sort-with-side-effecting-comparisons.js
similarity index 81%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/sort-with-side-effecting-comparisons.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..5dda02fa55b8ea09d25a2cce57ebc25faa29bf79 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/sort-with-side-effecting-comparisons.js
@@ -22,10 +22,23 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Checks that sorting an array with a side-effecting comparison function doesn't trigger assertions."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+var array = [];
+
+for (var i = 0; i < 20000; ++i)
+ array.push(i);
+
+array.sort(function(a, b) {
+ array.shift();
+ if (a < b)
+ return -1;
+ if (a > b)
+ return 1;
+ return 0;
+});
+
+testPassed("It worked.");
« no previous file with comments | « test/webkit/sort-randomly-expected.txt ('k') | test/webkit/sort-with-side-effecting-comparisons-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698