Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js
similarity index 79%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..d3e69b6dc94209d3dfb71e0ac92c5a1cdebf64b2 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js
@@ -22,10 +22,23 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Tests that using get_by_pname in a way that appears like a get_by_val that can be patched does not cause the patching machinery to crash."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+function foo() {
+ var o = [1, 2, 3];
+ var result = 0;
+
+ for (var i = 0; i < 100; ++i) {
+ for (var s in o) {
+ s = 0;
+ result += o[s];
+ }
+ }
+
+ return result;
+}
+
+shouldBe("foo()", "300");

Powered by Google App Engine
This is Rietveld 408576698