Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: test/webkit/dfg-to-string-valueOf-in-string.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/webkit/dfg-to-string-valueOf-in-string.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/dfg-to-string-valueOf-in-string.js
similarity index 75%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/dfg-to-string-valueOf-in-string.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..e591bf7fe7c8a90b452be3f2c3f56a8395de6e51 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/dfg-to-string-valueOf-in-string.js
@@ -22,10 +22,21 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Tests that we do ToString conversions correctly when String.prototype.valueOf is fine but we define our own on the String object itself."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+function foo(a) {
+ for (var i = 0; i < 100; ++i)
+ a = new String(a);
+ return a;
+}
+var argument = new String("hello");
+for (var i = 0; i < 150; ++i) {
+ if (i == 100) {
+ argument = new String("hello");
+ argument.valueOf = function() { return 42; }
+ }
+ shouldBe("\"\" + foo(argument)", "\"hello\"");
+}
« no previous file with comments | « test/webkit/dfg-to-string-toString-in-string-expected.txt ('k') | test/webkit/dfg-to-string-valueOf-in-string-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698