Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js
similarity index 52%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..54c049f1c2db335aad3db86eddce8545b37f26ec 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js
@@ -22,10 +22,46 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"Tests that when values predicted but not proven int are used in a tower of additions, we don't eliminate the overflow check unsoundly."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+function foo(a, b, o) {
+ return (a + b + o.f) | 0;
+}
+function bar(a, b, o) {
+ eval(""); // Prevent this function from being opt compiled.
+ return foo(a, b, o);
+}
+
+var badCases = [
+ {a:2147483645, b:2147483644, c:9007199254740990, expected:-8},
+ {a:2147483643, b:2147483643, c:18014398509481980, expected:-16},
+ {a:2147483643, b:2147483642, c:36028797018963960, expected:-16},
+ {a:2147483642, b:2147483642, c:36028797018963960, expected:-16},
+ {a:2147483641, b:2147483640, c:144115188075855840, expected:-32},
+ {a:2147483640, b:2147483640, c:144115188075855840, expected:-64},
+ {a:2147483640, b:2147483639, c:288230376151711680, expected:-64},
+ {a:2147483639, b:2147483639, c:288230376151711680, expected:-64}
+];
+
+var warmup = 100;
+
+for (var i = 0; i < warmup + badCases.length; ++i) {
+ var a, b, c;
+ var expected;
+ if (i < warmup) {
+ a = 1;
+ b = 2;
+ c = 3;
+ expected = 6;
+ } else {
+ var current = badCases[i - warmup];
+ a = current.a;
+ b = current.b;
+ c = current.c;
+ expected = current.expected;
+ }
+ shouldBe("bar(" + a + ", " + b + ", {f:" + c + "})", "" + expected);
+}

Powered by Google App Engine
This is Rietveld 408576698