Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: test/webkit/for-in-var-scope.js

Issue 18068003: Migrated several tests from blink to V8 repository. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/webkit/for-in-to-text-expected.txt ('k') | test/webkit/for-in-var-scope-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/webkit/for-in-var-scope.js
diff --git a/test/webkit/concat-while-having-a-bad-time.js b/test/webkit/for-in-var-scope.js
similarity index 71%
copy from test/webkit/concat-while-having-a-bad-time.js
copy to test/webkit/for-in-var-scope.js
index dfda1e08a0b36194b787a44ee12a9693acd8aeaf..7ac8e04a8748cd2d631ba36cd20c95b164e3561c 100644
--- a/test/webkit/concat-while-having-a-bad-time.js
+++ b/test/webkit/for-in-var-scope.js
@@ -22,10 +22,21 @@
// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
description(
-"Tests the behavior of Array.prototype.concat while the array is having a bad time due to one of the elements we are concatenating."
+"This tests that for/in statements properly scope a variable that's declared in one. "
++ "In previous versions of JavaScriptCore there were two bugs that caused problems. "
++ "First, the loop variable declaration would not be processed. "
++ "Second, the code to set the loop variable would incorrectly walk the scope chain even after setting the loop variable."
);
-Object.defineProperty(Array.prototype, 0, { writable: false });
-shouldBe("[42].concat()", "[42]");
+var i = "start i";
+var j = "start j";
+function func() {
+ var object = new Object;
+ object.propName = "propValue";
+ for (var i in object) { j = i; }
+}
+func();
+shouldBe("i", "'start i'");
+shouldBe("j", "'propName'");
« no previous file with comments | « test/webkit/for-in-to-text-expected.txt ('k') | test/webkit/for-in-var-scope-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698