Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1806733002: Support DEVELOPER_DIR in gyp-ninja for mac. (Closed)

Created:
4 years, 9 months ago by justincohen
Modified:
4 years, 9 months ago
Reviewers:
Nico, sdefresne
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Support DEVELOPER_DIR in gyp-ninja for mac. Adds DEVELOPER_DIR to gyp mac_tool.py, to LINK commands in ninja and to the default Xcode emulation environment. BUG= R=sdefresne@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/28340b46df65f2c84f7793470189a0b395e1c9a4

Patch Set 1 #

Patch Set 2 : Remove spaces around = #

Patch Set 3 : Change from enviroment variable to param #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M pylib/gyp/common.py View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M pylib/gyp/xcode_emulation.py View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
justincohen
I wonder if there's a better way to do this?
4 years, 9 months ago (2016-03-23 17:15:05 UTC) #4
sdefresne
lgtm but if possible I'd like to reduce the usage of environment variables in gyp_mac_tool.py ...
4 years, 9 months ago (2016-03-25 17:25:12 UTC) #5
justincohen
I changed this CL to use generator flags, but it still embeds os.environ['DEVELOPER_DIR'] in mac ...
4 years, 9 months ago (2016-03-26 20:54:48 UTC) #6
justincohen
4 years, 9 months ago (2016-03-26 21:48:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
28340b46df65f2c84f7793470189a0b395e1c9a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698