Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 1806723003: [Extensions] Remove principalsPrivate API (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Remove principalsPrivate API BUG=595168 Committed: https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198 Cr-Commit-Position: refs/heads/master@{#381591}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove extraneous mods #

Messages

Total messages: 11 (5 generated)
Devlin
4 years, 9 months ago (2016-03-16 05:01:40 UTC) #3
asargent_no_longer_on_chrome
lgtm w/ 1 question https://codereview.chromium.org/1806723003/diff/20001/chrome/test/data/extensions/api_test/bindings/function_interceptions.html File chrome/test/data/extensions/api_test/bindings/function_interceptions.html (right): https://codereview.chromium.org/1806723003/diff/20001/chrome/test/data/extensions/api_test/bindings/function_interceptions.html#newcode5 chrome/test/data/extensions/api_test/bindings/function_interceptions.html:5: var objects = ['runtime', 'require', ...
4 years, 9 months ago (2016-03-16 22:17:25 UTC) #4
Devlin
https://codereview.chromium.org/1806723003/diff/20001/chrome/test/data/extensions/api_test/bindings/function_interceptions.html File chrome/test/data/extensions/api_test/bindings/function_interceptions.html (right): https://codereview.chromium.org/1806723003/diff/20001/chrome/test/data/extensions/api_test/bindings/function_interceptions.html#newcode5 chrome/test/data/extensions/api_test/bindings/function_interceptions.html:5: var objects = ['runtime', 'require', 'test', 'binding', 'Binding', '$set', ...
4 years, 9 months ago (2016-03-16 22:58:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806723003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806723003/40001
4 years, 9 months ago (2016-03-16 22:58:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-16 23:47:52 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 23:50:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc99ab106086dcb7cd12542ac669c9bd4b8fe198
Cr-Commit-Position: refs/heads/master@{#381591}

Powered by Google App Engine
This is Rietveld 408576698