components/mus/public/cpp/input_event_handler.h - Issue 1806703002: Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/input_event_handler.h

Issue 1806703002: Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/mus/public/cpp/BUILD.gn ('k') | components/mus/public/cpp/lib/window_tree_client_impl.cc » ('j') | content/renderer/mus/compositor_mus_connection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/cpp/input_event_handler.h

diff --git a/components/mus/public/cpp/input_event_handler.h b/components/mus/public/cpp/input_event_handler.h

index 597653ba3d487163b8ad607b19d68ca8f898a6d5..7dff5cfcf859d819e72f52edbe31213bf99f7f6e 100644

--- a/components/mus/public/cpp/input_event_handler.h

+++ b/components/mus/public/cpp/input_event_handler.h

@@ -6,7 +6,7 @@

#define COMPONENTS_MUS_PUBLIC_CPP_INPUT_EVENT_HANDLER_H_

#include "base/callback_forward.h"

-#include "components/mus/public/interfaces/input_events.mojom.h"

+#include "ui/events/event.h"

sky 2016/03/16 18:12:34 You should be able to forward declare the event.

Hadi 2016/03/16 18:46:44 Done.

namespace mus {

@@ -21,7 +21,7 @@ class InputEventHandler {

// the callback, then WindowTreeClientImpl will ack the event as not consumed.

virtual void OnWindowInputEvent(

Window* target,

- mojom::EventPtr event,

+ ui::Event* event,

sky 2016/03/16 18:12:34 const ui::Event&?

Hadi 2016/03/16 18:46:43 Done. This was infected from PlatformWindowDelegat

scoped_ptr<base::Callback<void(bool)>>* ack_callback) = 0;

protected: