third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h - Issue 1806653002: Shape unicode-range: font faces in only one iteration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

Issue 1806653002: Shape unicode-range: font faces in only one iteration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update UnicodeRangeSetTests to RefPtrtr, rm copy constructor and test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

index a1a49b97fc88a5f05fa7f4b24ab87aee4390e7bb..719d6cf96904fadcc1218c8def84f60a015eb016 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h

@@ -53,6 +53,7 @@ class Font;

class GlyphBuffer;

class SimpleFontData;

class HarfBuzzShaper;

+class UnicodeRangeSet;

// Shaping text runs is split into several stages: Run segmentation, shaping the

// initial segment, identify shaped and non-shaped sequences of the shaping

@@ -162,8 +163,7 @@ private:

unsigned startIndex,

unsigned numCharacters,

const SimpleFontData* currentFont,

- unsigned currentFontRangeFrom,

- unsigned currentFontRangeTo,

+ PassRefPtr<UnicodeRangeSet> currentFontRangeSet,

UScriptCode currentRunScript,

hb_language_t);

bool extractShapeResults(hb_buffer_t* harfBuzzBuffer,