third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h - Issue 1806653002: Shape unicode-range: font faces in only one iteration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

Issue 1806653002: Shape unicode-range: font faces in only one iteration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update UnicodeRangeSetTests to RefPtrtr, rm copy constructor and test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

index 8e343ffd0d8244400ab1611568505b1e10c960ec..9f7c15a140927f7ae5b8e064eab60929d47d32b4 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

@@ -31,6 +31,7 @@

#ifndef HarfBuzzFace_h

#define HarfBuzzFace_h

+#include "platform/fonts/UnicodeRangeSet.h"

#include "wtf/Allocator.h"

#include "wtf/HashMap.h"

#include "wtf/Noncopyable.h"

@@ -60,7 +61,7 @@ public:

// In order to support the restricting effect of unicode-range optionally a

// range restriction can be passed in, which will restrict which glyphs we

// return in the harfBuzzGetGlyph function.

- hb_font_t* createFont(unsigned rangeFrom = 0, unsigned rangeTo = kMaxCodepoint) const;

+ hb_font_t* createFont(PassRefPtr<UnicodeRangeSet> = nullptr) const;

hb_face_t* face() const { return m_face; }

private: