third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp - Issue 1806653002: Shape unicode-range: font faces in only one iteration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp

Issue 1806653002: Shape unicode-range: font faces in only one iteration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update UnicodeRangeSetTests to RefPtrtr, rm copy constructor and test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp ('k') | third_party/WebKit/Source/platform/fonts/FontSelector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp b/third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp

index 135054105dd09ea4cd39aa128324b880b97a2a56..2dae03c51d19e7611dee6454dd2d7619586ac2dc 100644

--- a/third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp

+++ b/third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp

@@ -133,8 +133,8 @@ const SimpleFontData* FontFallbackList::determinePrimarySimpleFontData(const Fon

if (fontData->isSegmented()) {

const SegmentedFontData* segmented = toSegmentedFontData(fontData);

- for (unsigned i = 0; i < segmented->numRanges(); i++) {

- const SimpleFontData* rangeFontData = segmented->rangeAt(i).fontData().get();

+ for (unsigned i = 0; i < segmented->numFaces(); i++) {

+ const SimpleFontData* rangeFontData = segmented->faceAt(i).fontData().get();

if (!rangeFontData->isLoadingFallback())

return rangeFontData;

}