Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of https://codereview…

Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for Linux (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/26678) Windows (https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/46875) and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>;

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>;

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949, 594974
NOTRY=true

Committed: https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359
Cr-Commit-Position: refs/heads/master@{#381305}

[dewittj, 2016-03-15 20:23:50]

Rolls forward did not help the issue so I am proceeding with this revert.

csharp/dgozman: ptal?

[csharp, 2016-03-15 20:27:59]

This change doesn't seem to revert https://codereview.chromium.org/1807513002/,
are you going to put it here or do another revert?

[dewittj, 2016-03-15 20:28:30]

I am uploading that now.

[dewittj, 2016-03-15 20:31:26]

PTAL

[dewittj, 2016-03-15 20:33:17]

Description was changed from

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
==========

to

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>


R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
==========

[dewittj, 2016-03-15 20:33:39]

Description was changed from

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>


R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
==========

to

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>


R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

[dgozman, 2016-03-15 20:34:27]

On 2016/03/15 20:31:26, dewittj wrote:
> PTAL

Missed this one as well: https://codereview.chromium.org/1805543002

[dewittj, 2016-03-15 20:38:52]

Description was changed from

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>


R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

to

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

[dewittj, 2016-03-15 20:39:10]

dgozman, thanks.  I updated a new patch.

[csharp, 2016-03-15 20:41:01]

lgtm

[dewittj, 2016-03-15 20:41:57]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-03-15 20:42:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806643002/40001

[dgozman, 2016-03-15 20:42:24]

lgtm

Sorry for this. Turned out unlucky with no debug checks in v8 and first revert
not going through.

[commit-bot: I haz the power, 2016-03-15 20:49:53]

Description was changed from

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

to

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

[commit-bot: I haz the power, 2016-03-15 20:49:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-15 20:52:56]

Description was changed from

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true
==========

to

==========
Revert of Remove V8RecrusionScope, cleanup call sites. (patchset #8 id:140001 of
https://codereview.chromium.org/1769273004/ )

Reason for revert:
Speculative revert, this patch most likely to cause browser_tests failures for
Linux
(https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...)
Windows
(https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...)
and Mac

Original issue's description:
> Remove V8RecrusionScope, cleanup call sites.
>
> - blink-side usages migrated to v8::MicrotasksScope;
> - clients of WebScopedMicrotaskSuppression migrated to v8::MicrotasksScope;
> - moved Microtask.{h,cpp} to bindings/core/v8;
> - removed extra wrappers from V8DebuggerClient;
> - fixed a couple of inspector tests which relied on trace event not emitted
from debugger anymore.
>
> BUG=585949
>
> Committed: https://crrev.com/133a1579d2a087acdcdd4e9247062edb0bd1e5a3
> Cr-Commit-Position: refs/heads/master@{#381103}

Also reverts https://codereview.chromium.org/1807513002/,
commit 0d194e62ee499d1310e74537aecfa5c6543b8811
Author: dgozman <dgozman@chromium.org>

Also reverts https://codereview.chromium.org/1805543002
commit	974fa818537a8d00fb3537a836db79e2539a7889
Author:	dgozman <dgozman@chromium.org>

R=csharp@chromium.org
TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org
BUG=585949,594974
NOTRY=true

Committed: https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359
Cr-Commit-Position: refs/heads/master@{#381305}
==========

[commit-bot: I haz the power, 2016-03-15 20:52:59]

Patchset 3 (id:??) landed as
https://crrev.com/0bfd25d460a1cff98f9f0573a0d6cc072ecbe359
Cr-Commit-Position: refs/heads/master@{#381305}