Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1652)

Unified Diff: chrome/browser/autofill/content_autofill_driver_browsertest.cc

Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment addressed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/content_autofill_driver_browsertest.cc
diff --git a/chrome/browser/autofill/content_autofill_driver_browsertest.cc b/chrome/browser/autofill/content_autofill_driver_browsertest.cc
index 3c4eefb56f29c74840e9093e675a8eeb556dd96c..e60f12ce5f471aa2968731f8a7d94966369713c0 100644
--- a/chrome/browser/autofill/content_autofill_driver_browsertest.cc
+++ b/chrome/browser/autofill/content_autofill_driver_browsertest.cc
@@ -98,8 +98,8 @@ class ContentAutofillDriverBrowserTest : public InProcessBrowserTest,
web_contents_hidden_callback_.Run();
}
- void NavigationEntryCommitted(
- const content::LoadCommittedDetails& load_details) override {
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override {
if (!nav_entry_committed_callback_.is_null())
nav_entry_committed_callback_.Run();
}
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698