Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1806543002: Fix polymorphic keyed load handler selection for string elements (Closed)

Created:
4 years, 9 months ago by Jakob Kummerow
Modified:
4 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix polymorphic keyed load handler selection for string elements The monomorphic case already carefully ensures that we don't try to use a regular elements load stub on string wrapper elements. The polymorphic path must perform an equivalent check. BUG=chromium:594955 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/84dd29bb3c608e60d4fcd18d0250277e034e26a7 Cr-Commit-Position: refs/heads/master@{#34807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/ic/ic.cc View 2 chunks +9 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-594955.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 9 months ago (2016-03-15 14:18:16 UTC) #1
Toon Verwaest
LGTM for now, although it's a pretty ugly solution. We should just add support for ...
4 years, 9 months ago (2016-03-15 19:16:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806543002/1
4 years, 9 months ago (2016-03-16 10:07:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 10:55:16 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 10:56:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84dd29bb3c608e60d4fcd18d0250277e034e26a7
Cr-Commit-Position: refs/heads/master@{#34807}

Powered by Google App Engine
This is Rietveld 408576698