Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: ios/third_party/gcdwebserver/BUILD.gn

Issue 1806513002: Add config to enable ARC on iOS/OS X to //build/config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iossim
Patch Set: Remove //build/config/mac:macosx_version_min_10_9 config Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | ios/third_party/ochamcrest/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/third_party/gcdwebserver/BUILD.gn
diff --git a/ios/third_party/gcdwebserver/BUILD.gn b/ios/third_party/gcdwebserver/BUILD.gn
index 21b993cdd43efefd3b6e83e5255f9e2bfbd5bdbc..5207f75b5d0bb4e530722885cb84442cee25f7fa 100644
--- a/ios/third_party/gcdwebserver/BUILD.gn
+++ b/ios/third_party/gcdwebserver/BUILD.gn
@@ -2,7 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-config("public_config") {
+config("config") {
+ visibility = [ ":gcdwebserver" ]
libs = [
"CFNetwork.framework",
"MobileCoreServices.framework",
@@ -16,14 +17,13 @@ config("public_config") {
]
}
-config("internal_config") {
+config("private_config") {
visibility = [ ":gcdwebserver" ]
# TODO(crbug.com/569158): Suppresses warnings that are treated as errors
# when minimum iOS version support is increased to iOS 9 and up.
# This should be removed once all deprecation violations have been fixed.
Nico 2016/03/18 21:52:07 Somewhat drive-by: FWIW, I feel pretty strongly th
sdefresne 2016/03/19 13:34:27 I agree. pkl@ is owning the removal of those tempo
cflags = [ "-Wno-deprecated-declarations" ]
- cflags_objc = [ "-fobjc-arc" ]
}
source_set("gcdwebserver") {
@@ -60,6 +60,9 @@ source_set("gcdwebserver") {
"src/GCDWebServer/Responses/GCDWebServerStreamedResponse.m",
]
- public_configs = [ ":public_config" ]
- configs += [ ":internal_config" ]
+ public_configs = [ ":config" ]
+ configs += [
+ ":private_config",
+ "//build/config/compiler:enable_arc",
+ ]
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | ios/third_party/ochamcrest/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698