Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1806503002:
[iOS] Defaults to use system libjpeg on iOS. (Closed)
Description[iOS] Defaults to use system libjpeg on iOS.
It is currently not possible to build libjpeg_turbo on iOS (and may
not be a good idea in term of application size) so default to using
the version of libjpeg shipped with the system.
Move the "libs" assignment from the "jpeg" to "system_libjpeg_config"
config.
BUG=459705
Committed: https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313
Cr-Commit-Position: refs/heads/master@{#381432}
Patch Set 1 #
Messages
Total messages: 14 (4 generated)
sdefresne@chromium.org changed reviewers: + brettw@chromium.org
Please take a look.
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806503002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Defaults to use system libjpeg on iOS. It is currently not possible to build libjpeg_turbo on iOS (and may not be a good idea in term of application size) so default to using the version of libjpeg shipped with the system. Move the "libs" assignment from the "jpeg" to "system_libjpeg_config" config. BUG=459705 ========== to ========== [iOS] Defaults to use system libjpeg on iOS. It is currently not possible to build libjpeg_turbo on iOS (and may not be a good idea in term of application size) so default to using the version of libjpeg shipped with the system. Move the "libs" assignment from the "jpeg" to "system_libjpeg_config" config. BUG=459705 Committed: https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 Cr-Commit-Position: refs/heads/master@{#381432} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 Cr-Commit-Position: refs/heads/master@{#381432}
Message was sent while issue was closed.
On 2016/03/16 11:10:44, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 > Cr-Commit-Position: refs/heads/master@{#381432} May I ask why this was a GN-only change, since use_system_libjpeg is always 0 in https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi ? I'm wondering since I've been spending some time on trying to get WebRTC build for GN iOS again and I'm currently stuck on missing the jpeg library: $ ninja -C out/Default frame_analyzer ninja: Entering directory `out/Default' [1/1] LINK ./frame_analyzer FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk -stdlib=libc++ -mios-simulator-version-min=9.0 -o "./frame_analyzer" -Wl,-filelist,"./frame_analyzer.rsp" -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework CoreVideo -ljpeg ld: library not found for -ljpeg clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. If I instead try to build libjpeg_turbo, I run into a build error like you said: $ gn gen --args="target_os=\"ios\" use_system_libjpeg=false" out/Default $ ninja -C out/Default frame_analyzer ninja: Entering directory `out/Default' [11/105] ACTION //third_party/libjpeg_turbo:simd_asm_action(//build/toolchain/mac:ios_clang_arm) FAILED: python ../../third_party/yasm/run_yasm.py ./clang_x64/yasm -fmacho64 -m amd64 -I. -I../.. -Igen -D__x86_64__ -o obj/third_party/libjpeg_turbo/jcqnts2f-64.o ../../third_party/libjpeg_turbo/simd/jcqnts2f-64.asm yasm: FATAL: unable to open include file `jsimdcfg.inc' ... Shouldn't the proper fix be to add the (missing?) support for .inc files to GN so yasm can work (or is the problem somewhere else?).
Message was sent while issue was closed.
On 2016/04/06 at 17:09:30, kjellander wrote: > On 2016/03/16 11:10:44, commit-bot: I haz the power wrote: > > Patchset 1 (id:??) landed as > > https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 > > Cr-Commit-Position: refs/heads/master@{#381432} > > May I ask why this was a GN-only change, since use_system_libjpeg is always 0 in https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi ? > > I'm wondering since I've been spending some time on trying to get WebRTC build for GN iOS again and I'm currently stuck on missing the jpeg library: > $ ninja -C out/Default frame_analyzer > ninja: Entering directory `out/Default' > [1/1] LINK ./frame_analyzer > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk -stdlib=libc++ -mios-simulator-version-min=9.0 -o "./frame_analyzer" -Wl,-filelist,"./frame_analyzer.rsp" -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework CoreVideo -ljpeg > ld: library not found for -ljpeg > clang: error: linker command failed with exit code 1 (use -v to see invocation) > ninja: build stopped: subcommand failed. > > If I instead try to build libjpeg_turbo, I run into a build error like you said: > > $ gn gen --args="target_os=\"ios\" use_system_libjpeg=false" out/Default > $ ninja -C out/Default frame_analyzer > ninja: Entering directory `out/Default' > [11/105] ACTION //third_party/libjpeg_turbo:simd_asm_action(//build/toolchain/mac:ios_clang_arm) > FAILED: python ../../third_party/yasm/run_yasm.py ./clang_x64/yasm -fmacho64 -m amd64 -I. -I../.. -Igen -D__x86_64__ -o obj/third_party/libjpeg_turbo/jcqnts2f-64.o ../../third_party/libjpeg_turbo/simd/jcqnts2f-64.asm > yasm: FATAL: unable to open include file `jsimdcfg.inc' > ... > Shouldn't the proper fix be to add the (missing?) support for .inc files to GN so yasm can work (or is the problem somewhere else?). Looks like adding the way to go. Can you please file a crbug and assigned to me?
Message was sent while issue was closed.
On 2016/04/06 at 22:36:31, sdefresne wrote: > On 2016/04/06 at 17:09:30, kjellander wrote: > > On 2016/03/16 11:10:44, commit-bot: I haz the power wrote: > > > Patchset 1 (id:??) landed as > > > https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 > > > Cr-Commit-Position: refs/heads/master@{#381432} > > > > May I ask why this was a GN-only change, since use_system_libjpeg is always 0 in https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi ? > > > > I'm wondering since I've been spending some time on trying to get WebRTC build for GN iOS again and I'm currently stuck on missing the jpeg library: > > $ ninja -C out/Default frame_analyzer > > ninja: Entering directory `out/Default' > > [1/1] LINK ./frame_analyzer > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk -stdlib=libc++ -mios-simulator-version-min=9.0 -o "./frame_analyzer" -Wl,-filelist,"./frame_analyzer.rsp" -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation -framework CoreVideo -ljpeg > > ld: library not found for -ljpeg > > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > ninja: build stopped: subcommand failed. > > > > If I instead try to build libjpeg_turbo, I run into a build error like you said: > > > > $ gn gen --args="target_os=\"ios\" use_system_libjpeg=false" out/Default > > $ ninja -C out/Default frame_analyzer > > ninja: Entering directory `out/Default' > > [11/105] ACTION //third_party/libjpeg_turbo:simd_asm_action(//build/toolchain/mac:ios_clang_arm) > > FAILED: python ../../third_party/yasm/run_yasm.py ./clang_x64/yasm -fmacho64 -m amd64 -I. -I../.. -Igen -D__x86_64__ -o obj/third_party/libjpeg_turbo/jcqnts2f-64.o ../../third_party/libjpeg_turbo/simd/jcqnts2f-64.asm > > yasm: FATAL: unable to open include file `jsimdcfg.inc' > > ... > > Shouldn't the proper fix be to add the (missing?) support for .inc files to GN so yasm can work (or is the problem somewhere else?). > > Looks like adding the way to go. Can you please file a crbug and assigned to me? Will address as https://bugs.chromium.org/p/chromium/issues/detail?id=602682.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1882123002/ by sdefresne@chromium.org. The reason for reverting is: Chrome on iOS does not link against libjpeg (neither libjpeg_turbo nor libjpeg) and build using libjpeg_turbo when using gyp. There is no path between //:gn_all and //third_party:jpeg, thus no need to select one version or the other on iOS. Revert the change as it causes link error for WebRTC. $ gn path out/simulator //:gn_all //third_party:jpeg No non-data paths found between these two targets. .
Message was sent while issue was closed.
On 2016/04/12 17:15:16, sdefresne wrote: > On 2016/04/06 at 22:36:31, sdefresne wrote: > > On 2016/04/06 at 17:09:30, kjellander wrote: > > > On 2016/03/16 11:10:44, commit-bot: I haz the power wrote: > > > > Patchset 1 (id:??) landed as > > > > https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 > > > > Cr-Commit-Position: refs/heads/master@{#381432} > > > > > > May I ask why this was a GN-only change, since use_system_libjpeg is always > 0 in > https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi ? > > > > > > I'm wondering since I've been spending some time on trying to get WebRTC > build for GN iOS again and I'm currently stuck on missing the jpeg library: > > > $ ninja -C out/Default frame_analyzer > > > ninja: Entering directory `out/Default' > > > [1/1] LINK ./frame_analyzer > > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch > x86_64 -isysroot > /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk > -stdlib=libc++ -mios-simulator-version-min=9.0 -o "./frame_analyzer" > -Wl,-filelist,"./frame_analyzer.rsp" -framework CoreFoundation -framework > CoreGraphics -framework CoreText -framework Foundation -framework CoreVideo > -ljpeg > > > ld: library not found for -ljpeg > > > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > > ninja: build stopped: subcommand failed. > > > > > > If I instead try to build libjpeg_turbo, I run into a build error like you > said: > > > > > > $ gn gen --args="target_os=\"ios\" use_system_libjpeg=false" out/Default > > > $ ninja -C out/Default frame_analyzer > > > ninja: Entering directory `out/Default' > > > [11/105] ACTION > //third_party/libjpeg_turbo:simd_asm_action(//build/toolchain/mac:ios_clang_arm) > > > FAILED: python ../../third_party/yasm/run_yasm.py ./clang_x64/yasm -fmacho64 > -m amd64 -I. -I../.. -Igen -D__x86_64__ -o > obj/third_party/libjpeg_turbo/jcqnts2f-64.o > ../../third_party/libjpeg_turbo/simd/jcqnts2f-64.asm > > > yasm: FATAL: unable to open include file `jsimdcfg.inc' > > > ... > > > Shouldn't the proper fix be to add the (missing?) support for .inc files to > GN so yasm can work (or is the problem somewhere else?). > > > > Looks like adding the way to go. Can you please file a crbug and assigned to > me? > > Will address as https://bugs.chromium.org/p/chromium/issues/detail?id=602682. Oh, I didn't see the previous message as I was not added as reviewer or CC to the CL - Rietveld seems to not do that by default anymore. Thanks for following up on this, highly appreciated!
Message was sent while issue was closed.
Description was changed from ========== [iOS] Defaults to use system libjpeg on iOS. It is currently not possible to build libjpeg_turbo on iOS (and may not be a good idea in term of application size) so default to using the version of libjpeg shipped with the system. Move the "libs" assignment from the "jpeg" to "system_libjpeg_config" config. BUG=459705 Committed: https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 Cr-Commit-Position: refs/heads/master@{#381432} ========== to ========== [iOS] Defaults to use system libjpeg on iOS. It is currently not possible to build libjpeg_turbo on iOS (and may not be a good idea in term of application size) so default to using the version of libjpeg shipped with the system. Move the "libs" assignment from the "jpeg" to "system_libjpeg_config" config. BUG=459705 Committed: https://crrev.com/689dc0e45d16789f3ce3241d3033601af395c313 Cr-Commit-Position: refs/heads/master@{#381432} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
