TaskScheduler [9] Delayed Task Manager

base/task_scheduler/utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/task_scheduler/utils.h"
 
 #include <utility>
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
+#include "base/task_scheduler/delayed_task_manager.h"
 #include "base/task_scheduler/priority_queue.h"
 #include "base/task_scheduler/scheduler_task_executor.h"
 #include "base/task_scheduler/sequence_sort_key.h"
 #include "base/task_scheduler/task_tracker.h"
 #include "base/time/time.h"
 
 namespace base {
 namespace internal {
 
 bool PostTaskToExecutor(const tracked_objects::Location& posted_from,
                         const Closure& closure,
                         const TaskTraits& traits,
                         const TimeDelta& delay,
                         scoped_refptr<Sequence> sequence,
                         SchedulerTaskExecutor* executor,
-                        TaskTracker* task_tracker) {
+                        TaskTracker* task_tracker,
+                        DelayedTaskManager* delayed_task_manager) {
   DCHECK(!closure.is_null());
   DCHECK(sequence);
   DCHECK(executor);
   DCHECK(task_tracker);
-
-  // TODO(fdoray): Support delayed tasks.
-  DCHECK(delay.is_zero());
+  DCHECK(delayed_task_manager);
 
   std::unique_ptr<Task> task(new Task(posted_from, closure, traits));

[gab, 2016/04/15 15:39:10]

TrackingInfo (Task's subsubclass) has a constructor parameter to set
|delayed_run_time|, is it worth using that instead of altering it below?
(otherwise it'll be confusing later to a reader of task.h that it never declares
a delay whereas a constructor will allow this reader to see where it's used
from)

[fdoray, 2016/04/15 17:41:47]

Done. Related CL: https://codereview.chromium.org/1890163003/

+  if (!delay.is_zero())
+    task->delayed_run_time = TimeTicks::Now() + delay;
 
   if (!task_tracker->WillPostTask(task.get()))
     return false;
 
-  executor->PostTaskWithSequence(std::move(task), std::move(sequence));
+  if (delay.is_zero()) {
+    executor->PostTaskWithSequence(std::move(task), std::move(sequence));
+  } else {
+    delayed_task_manager->AddDelayedTask(std::move(task), std::move(sequence),
+                                         executor);
+  }
+
   return true;
 }
 
 bool AddTaskToSequenceAndPriorityQueue(std::unique_ptr<Task> task,
                                        scoped_refptr<Sequence> sequence,
                                        PriorityQueue* priority_queue) {
   DCHECK(task);
   DCHECK(sequence);
   DCHECK(priority_queue);
 
@@ skipping 13 matching lines @@
     priority_queue->BeginTransaction()->Push(
         WrapUnique(new PriorityQueue::SequenceAndSortKey(std::move(sequence),
                                                          sequence_sort_key)));
   }
 
   return sequence_was_empty;
 }
 
 }  // namespace internal
 }  // namespace base