Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 1806403002: [MIPS] Fix build issue with browser tests when using mipsel-nacl-clang (Closed)

Created:
4 years, 9 months ago by petarj
Modified:
4 years, 9 months ago
Reviewers:
bradnelson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Fix build issue with browser tests when using mipsel-nacl-clang Remove options that were valid for pnacl toolchain but are not valid for mipsel-nacl-clang. This fixes the build issues: mipsel-nacl-clang: error: unsupported option '--pnacl-mips-bias' mipsel-nacl-clang: error: unsupported option '--pnacl-allow-translate' Committed: https://crrev.com/e73a0c6465bda610f980f7cb68ca4c1770241530 Cr-Commit-Position: refs/heads/master@{#381801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/test/data/nacl/nacl_test_data.gyp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
petarj
PTAL. This fixes a buildbot failure at local Chromium-NaCl buildbot: http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_with_pnacl/builds/718/steps/Build%20Chromium/logs/stdio
4 years, 9 months ago (2016-03-17 19:06:48 UTC) #3
bradnelson
lgtm
4 years, 9 months ago (2016-03-17 19:50:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806403002/1
4 years, 9 months ago (2016-03-17 19:51:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 21:32:52 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 21:34:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e73a0c6465bda610f980f7cb68ca4c1770241530
Cr-Commit-Position: refs/heads/master@{#381801}

Powered by Google App Engine
This is Rietveld 408576698