Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5267)

Unified Diff: chrome/browser/importer/external_process_importer_client.cc

Issue 18064002: The browser importer code which runs in the utility process should not depend on chrome\browser dat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/importer/external_process_importer_client.cc
===================================================================
--- chrome/browser/importer/external_process_importer_client.cc (revision 208948)
+++ chrome/browser/importer/external_process_importer_client.cc (working copy)
@@ -13,8 +13,6 @@
#include "chrome/browser/importer/importer_host.h"
#include "chrome/browser/importer/in_process_importer_bridge.h"
#include "chrome/browser/importer/profile_import_process_messages.h"
-#include "chrome/browser/search_engines/template_url.h"
-#include "chrome/browser/search_engines/template_url_service.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/utility_process_host.h"
#include "grit/generated_resources.h"
@@ -103,6 +101,8 @@
OnPasswordFormImportReady)
IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyKeywordsReady,
OnKeywordsImportReady)
+ IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyFirefoxSearchEngData,
+ OnFirefoxSearchEngineDataReceived)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -229,13 +229,18 @@
}
void ExternalProcessImporterClient::OnKeywordsImportReady(
- const std::vector<TemplateURL*>& template_urls,
+ const std::vector<importer::URLKeywordInfo>& url_keywords,
bool unique_on_host_and_path) {
if (cancelled_)
return;
+ bridge_->SetKeywords(url_keywords, unique_on_host_and_path);
+}
- bridge_->SetKeywords(template_urls, unique_on_host_and_path);
- // The pointers in |template_urls| have now been deleted.
+void ExternalProcessImporterClient::OnFirefoxSearchEngineDataReceived(
+ const std::vector<std::string> search_engine_data) {
+ if (cancelled_)
+ return;
+ bridge_->SetFirefoxSearchEnginesXMLData(search_engine_data);
}
ExternalProcessImporterClient::~ExternalProcessImporterClient() {}
« no previous file with comments | « chrome/browser/importer/external_process_importer_client.h ('k') | chrome/browser/importer/firefox3_importer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698