third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py - Issue 1806393002: Run yapf on files in webkit/layout_tests/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

Issue 1806393002: Run yapf on files in webkit/layout_tests/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

index 850db909797ca967383dfd990aafa62b7988a7e2..b62643d4f559822097b6a46d14ccb6f714639950 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py

@@ -32,7 +32,6 @@ import shlex

from webkitpy.layout_tests.breakpad.dump_reader import DumpReader

_log = logging.getLogger(__name__)

@@ -116,10 +115,7 @@ class DumpReaderWin(DumpReader):

depot_tools = self._find_depot_tools_path()

if depot_tools:

win_sdk = os.path.join(depot_tools, 'win_toolchain', 'vs2013_files', 'win_sdk')

- possible_cdb_locations.extend([

- '%s\\Debuggers\\x86' % win_sdk,

- '%s\\Debuggers\\x64' % win_sdk,

- ])

+ possible_cdb_locations.extend(['%s\\Debuggers\\x86' % win_sdk, '%s\\Debuggers\\x64' % win_sdk, ])

for cdb_path in possible_cdb_locations:

cdb = self._host.filesystem.join(cdb_path, 'cdb.exe')