Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1806383002: Revert of Remove uses of SkImageDecoder from gms (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
msarett, scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Remove uses of SkImageDecoder from gms (patchset #2 id:20001 of https://codereview.chromium.org/1791583002/ ) Reason for revert: Suspected of causing assertion failures in unrelated tests on Windows. Original issue's description: > Remove uses of SkImageDecoder from gms > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1791583002 > > Committed: https://skia.googlesource.com/skia/+/d427266a58af7e6ea6c12c9cd56ade3e179a0c04 TBR=scroggo@google.com,reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/003571887de747942478e33d4e2ff40bf3a65a72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -26 lines) Patch
M gm/astcbitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/avoidxfermode.cpp View 2 chunks +12 lines, -1 line 0 comments Download
A gm/cmykjpeg.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
M gm/copyTo4444.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/downsamplebitmap.cpp View 2 chunks +16 lines, -5 lines 0 comments Download
M gm/etc1bitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/factory.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/filterbitmap.cpp View 2 chunks +21 lines, -11 lines 0 comments Download
M gm/filterindiabox.cpp View 2 chunks +16 lines, -5 lines 0 comments Download
M gm/pixelxorxfermode.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M gm/showmiplevels.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/tiledscaledbitmap.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
Created Revert of Remove uses of SkImageDecoder from gms
4 years, 9 months ago (2016-03-17 17:38:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806383002/1
4 years, 9 months ago (2016-03-17 17:38:25 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:38:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/003571887de747942478e33d4e2ff40bf3a65a72

Powered by Google App Engine
This is Rietveld 408576698