Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: mojo/shell/background/background_shell.cc

Issue 1806353003: Adds option to run browser tests in mash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/background/background_shell.cc
diff --git a/mojo/shell/background/background_shell.cc b/mojo/shell/background/background_shell.cc
index ed1d5c54a6607250d02296e2faa095f3e2288c6b..a21bbe43038bbad2327ac2b0184e8a2d27654d6f 100644
--- a/mojo/shell/background/background_shell.cc
+++ b/mojo/shell/background/background_shell.cc
@@ -102,6 +102,11 @@ class BackgroundShell::MojoThread : public base::SimpleThread {
Join();
}
+ void RunShellCallback(const BackgroundShell::ShellThreadCallback& callback) {
+ DCHECK_EQ(message_loop_, base::MessageLoop::current());
+ callback.Run(context_->shell());
+ }
+
// base::SimpleThread:
void Start() override {
DCHECK(!message_loop_);
@@ -113,12 +118,6 @@ class BackgroundShell::MojoThread : public base::SimpleThread {
// in the order here.
scoped_ptr<base::MessageLoop> message_loop(message_loop_);
- Context::EnsureEmbedderIsInitialized();
-
- message_loop_->BindToCurrentThread();
-
- scoped_ptr<Context> context(new Context);
- context_ = context.get();
scoped_ptr<mojo::shell::Context::InitParams> context_init_params(
new mojo::shell::Context::InitParams);
if (init_params_) {
@@ -126,7 +125,15 @@ class BackgroundShell::MojoThread : public base::SimpleThread {
std::move(init_params_->catalog_store);
context_init_params->native_runner_delegate =
init_params_->native_runner_delegate;
+ context_init_params->init_edk = init_params_->init_edk;
}
+ if (context_init_params->init_edk)
+ Context::EnsureEmbedderIsInitialized();
+
+ message_loop_->BindToCurrentThread();
+
+ scoped_ptr<Context> context(new Context);
+ context_ = context.get();
context_->Init(std::move(context_init_params));
message_loop_->Run();
@@ -191,5 +198,12 @@ mojom::ShellClientRequest BackgroundShell::CreateShellClientRequest(
return request;
}
+void BackgroundShell::ExecuteOnShellThread(
+ const ShellThreadCallback& callback) {
+ thread_->message_loop()->task_runner()->PostTask(
+ FROM_HERE, base::Bind(&MojoThread::RunShellCallback,
+ base::Unretained(thread_.get()), callback));
+}
+
} // namespace shell
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698