Adds option to run browser tests in mash

Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733
Committed: https://crrev.com/6e47685c9153b1d26ce5d2f955ebd6aea67e09d3
Cr-Commit-Position: refs/heads/master@{#382305}

[sky, 2016-03-17 21:22:53]

At this point the parts worth looking at are mojo_test_connector, and
mash_browser_tests_main. The rest are just support of that.

[sky, 2016-03-19 00:45:29]

Description was changed from

==========
WIP: Adds option to run browser tests in mash

This still has a bit to go, but it's mostly there. At a high level this is
what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic beause I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector does a connect for each test. The connect is done
  with child process connection. The base test launching code handles
  the actual process launching.

To make this work I had to add functionality to random places to allow
me to inject/override what I needed. I'll split this patch up into
smaller chunks, but wanted to make sure you are ok with general
direction.

Other random notes:
. --single_process is a slightly different flow.
. Launching more than one test doesn't work. I suspect I'll need to
  change the catalog to support it.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits.

R=ben@chromium.org
BUG=
==========

to

==========
Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733
==========

[sky, 2016-03-19 00:45:29]

sky@chromium.org changed reviewers:
+ jam@chromium.org

[sky, 2016-03-19 00:46:16]

Ok, this is ready to go. John, can you take a look as Ben is out?

[Ben Goodger (Google), 2016-03-19 03:24:53]

lgtm

https://codereview.chromium.org/1806353003/diff/80001/chrome/test/base/mash_b...
File chrome/test/base/mash_browser_tests_main.cc (right):

https://codereview.chromium.org/1806353003/diff/80001/chrome/test/base/mash_b...
chrome/test/base/mash_browser_tests_main.cc:100:
content::MojoShellConnection::Factory shell_connection_factory;
nit: indent

[sky, 2016-03-21 15:03:35]

The CQ bit was checked by sky@chromium.org

[sky, 2016-03-21 15:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1806353003/#ps100001
(title: "format")

[commit-bot: I haz the power, 2016-03-21 15:03:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806353003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806353003/100001

[commit-bot: I haz the power, 2016-03-21 16:38:44]

Description was changed from

==========
Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733
==========

to

==========
Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733
==========

[commit-bot: I haz the power, 2016-03-21 16:38:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-21 16:40:01]

Description was changed from

==========
Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733
==========

to

==========
Adds option to run browser tests in mash

At a high level this is what the code does:
. The test launcher creates MojoTestConnector.
. MojoTestConnector creates a BackgroundShell (initially I wanted to
  run the shell on the same thread, but that is problematic because I
  need to run a nested message loop at times, which the IO thread
  doesn't support (the test launcher uses an io thread)).
. A connection is established to mojo:mash_shell.
. MojoTestConnector sets up the state for each test. The connect is not done
  with Mojo's child process connection. The base test launching code handles
  the actual process launching.

Other random notes:
. --single_process is a slightly different flow.
. The test never finishes. This is because apps that are started don't
  all exit when the shell exits. I'm going to look at that next.

R=ben@chromium.org, jam@chromium.org
BUG=581733

Committed: https://crrev.com/6e47685c9153b1d26ce5d2f955ebd6aea67e09d3
Cr-Commit-Position: refs/heads/master@{#382305}
==========

[commit-bot: I haz the power, 2016-03-21 16:40:02]

Patchset 6 (id:??) landed as
https://crrev.com/6e47685c9153b1d26ce5d2f955ebd6aea67e09d3
Cr-Commit-Position: refs/heads/master@{#382305}

[sky, 2016-03-21 16:44:42]

https://codereview.chromium.org/1806353003/diff/80001/chrome/test/base/mash_b...
File chrome/test/base/mash_browser_tests_main.cc (right):

https://codereview.chromium.org/1806353003/diff/80001/chrome/test/base/mash_b...
chrome/test/base/mash_browser_tests_main.cc:100:
content::MojoShellConnection::Factory shell_connection_factory;
On 2016/03/19 03:24:53, Ben Goodger (Google) wrote:
> nit: indent

Done.