Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6191)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer.h

Issue 1806353002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_observer.h
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer.h b/chrome/browser/ui/sync/one_click_signin_sync_observer.h
index 6bf3c02491f66e07bfb724415c77416fbc30fb9e..225b45159f6e1f80e2f4359911e9964d319470d7 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_observer.h
+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer.h
@@ -7,6 +7,8 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
#include "components/sync_driver/sync_service_observer.h"
#include "content/public/browser/web_contents_observer.h"
#include "url/gurl.h"
@@ -24,6 +26,9 @@ class OneClickSigninSyncObserver : public content::WebContentsObserver,
// |continue_url|. Instances of this class delete themselves once the job is
// done.
Roger Tawa OOO till Jul 10th 2016/03/23 01:14:15 Can you add docs for the new args. In particular
Moe 2016/03/24 00:02:40 Done.
OneClickSigninSyncObserver(content::WebContents* web_contents,
+ Profile* profile,
+ Browser* browser,
+ const GURL& activity_controls_url,
const GURL& continue_url);
protected:
@@ -48,6 +53,13 @@ class OneClickSigninSyncObserver : public content::WebContentsObserver,
static void DeleteObserver(
base::WeakPtr<OneClickSigninSyncObserver> observer);
+ Profile* profile_;
+
+ Browser* browser_;
+
+ // The URL of the 'Activity controls' section of the privacy settings page.
+ const GURL activity_controls_url_;
+
// The URL to redirect to once Sync is initialized.
const GURL continue_url_;

Powered by Google App Engine
This is Rietveld 408576698