chrome/browser/ui/webui/signin/sync_confirmation_handler.h - Issue 1806353002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler.h

Issue 1806353002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments, fixed deprecated shadow piercing Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/sync_confirmation_handler.h

diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_handler.h b/chrome/browser/ui/webui/signin/sync_confirmation_handler.h

index cb3506a7030b6861d8c70afe9e32015047d76033..b2ff4b6befd8bcc91492771bc786f6562fd1c7f1 100644

--- a/chrome/browser/ui/webui/signin/sync_confirmation_handler.h

+++ b/chrome/browser/ui/webui/signin/sync_confirmation_handler.h

@@ -57,7 +57,8 @@ class SyncConfirmationHandler : public content::WebUIMessageHandler,

Browser* GetDesktopBrowser();

void CloseModalSigninWindow(

- LoginUIService::SyncConfirmationUIClosedResults results);

+ LoginUIService::SyncConfirmationUIClosedResults results,

+ const base::ListValue* args);

anthonyvd 2016/03/19 19:50:58 I'd parse |args| in the callers and make this just

Moe 2016/03/21 20:47:28 Done.

DISALLOW_COPY_AND_ASSIGN(SyncConfirmationHandler);

};