chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc - Issue 1806353002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Issue 1806353002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/sync/one_click_signin_sync_observer.h ('K') | « chrome/browser/ui/sync/one_click_signin_sync_starter.cc ('k') | chrome/browser/ui/webui/signin/login_ui_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

index defc7b14ced891038a8302fbd8c366401fb8da15..b301c6e789669c38b2005221803e22f6d09b8ca4 100644

--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

@@ -23,7 +23,7 @@ const int kPasswordCombinedFixedGaiaViewWidth = 360;

const int kFixedGaiaViewHeight = 512;

const int kFixedGaiaViewWidth = 448;

const int kSyncConfirmationDialogWidth = 448;

-const int kSyncConfirmationDialogHeight = 351;

+const int kSyncConfirmationDialogHeight = 511;

Dan Beam 2016/04/04 23:48:38 i think hardcoded heights based on localized, dyna

Moe 2016/04/05 17:14:42 anthonyvd@ is working on a fix to make these dynam

SigninViewControllerDelegateViews::SigninViewControllerDelegateViews(

SigninViewController* signin_view_controller,