Enhanced Sync Confirmation modal

chrome/browser/ui/webui/signin/login_ui_service.h

Index: chrome/browser/ui/webui/signin/login_ui_service.h
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.h b/chrome/browser/ui/webui/signin/login_ui_service.h
index ce3ffead914a26b9fa92f857195ef44f7c4c5216..d1e3f5ebeb0ab4a783fad195d84e01fe86725b57 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.h
+++ b/chrome/browser/ui/webui/signin/login_ui_service.h
@@ -33,13 +33,15 @@ class LoginUIService : public KeyedService {
 
   // Used when the sync confirmation UI is closed to signify which option was
   // selected by the user.
-  enum SyncConfirmationUIClosedResults {
+  enum SyncConfirmationUIClosedResult {
+    // Open the activity controls URL.
+    OPEN_ACTIVITY_CONTROLS_URL = 1U << 0,

[Evan Stade, 2016/03/31 19:30:53]

do you need these Us?

[Moe, 2016/03/31 21:00:49]

They're definitely not needed. I thought it's probably a good idea if the number
literals are also unsigned.

     // Start sync immediately.
-    SYNC_WITH_DEFAULT_SETTINGS,
+    SYNC_WITH_DEFAULT_SETTINGS = 1U << 1,
     // Show the user the sync settings before starting sync.
-    CONFIGURE_SYNC_FIRST,
+    CONFIGURE_SYNC_FIRST = 1U << 2,
     // The signing process was aborted, don't start sync or show settings.
-    ABORT_SIGNIN,
+    ABORT_SIGNIN = 1U << 3,
   };
 
   // Interface for obervers of LoginUIService.
@@ -55,8 +57,7 @@ class LoginUIService : public KeyedService {
 
     // Called when the sync confirmation UI is closed. |results| indicates the
     // option chosen by the user in the confirmation UI.
-    virtual void OnSyncConfirmationUIClosed(
-        SyncConfirmationUIClosedResults results) {}
+    virtual void OnSyncConfirmationUIClosed(uint32_t result) {}
 
     // Called when a confirmation UI for untrusted signin is shown.
     virtual void OnUntrustedLoginUIShown() {}
@@ -86,7 +87,7 @@ class LoginUIService : public KeyedService {
   void LoginUIClosed(LoginUI* ui);
 
   // Called when the sync settings confirmation UI is closed.

[Evan Stade, 2016/03/31 19:30:53]

can you add some docs about what result is, now that the type is not as helpful?

[Moe, 2016/03/31 21:00:49]

Done.

-  void SyncConfirmationUIClosed(SyncConfirmationUIClosedResults results);
+  void SyncConfirmationUIClosed(uint32_t result);
 
   // Called when a confirmation UI for untrusted signin is shown.
   void UntrustedLoginUIShown();