chrome/browser/ui/sync/one_click_signin_sync_starter.h - Issue 1806353002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 1806353002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

index 5cc33693280cd3b14a79b0756c355bc203ec2cbd..8d1ff5dc8fec29498523f68c562798df1cf2531b 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

@@ -132,7 +132,7 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

// LoginUIService::Observer override.

void OnSyncConfirmationUIClosed(

- LoginUIService::SyncConfirmationUIClosedResults results) override;

+ LoginUIService::SyncConfirmationUIClosedResult result) override;

// User input handler for the signin confirmation dialog.

class SigninDialogDelegate

@@ -195,6 +195,8 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

// call FinishProfileSyncServiceSetup() function.

ProfileSyncService* GetProfileSyncService();

+ void SetFirstSetupComplete();

void FinishProfileSyncServiceSetup();

// Displays the settings UI and brings up the advanced sync settings