Enhanced Sync Confirmation modal

tools/metrics/actions/actions.xml

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <!--
 This file is a comprehensive list of Chrome user actions along with the owner
 and description for each user action. A user action should be tied to an actual
 action taken by a user. It should be logged immediately after a user takes the
@@ skipping 12654 matching lines @@
     Recorded on sign in start from access point
     signin_metrics::AccessPoint::ACCESS_POINT_USER_MANAGER.
   </description>
 </action>
 
 <action name="Signin_Signin_Succeed">
   <owner>gogerald@chromium.org</owner>
   <description>Recorded when user sign in was successful.</description>
 </action>
 
+<action name="Signin_Signin_WithActivityControlsCheckbox">

[rkaplow, 2016/03/22 14:57:01]

user actions generally are related to a specific action a user made.

Would this make more sense as a binary histogram which would record the
open_activity_controls_url state? As it is, there is no easy baseline (i.e. to
see how after open_activity_controls_url==false occurs).

Maybe you could share more what you're trying to learn.

[Moe, 2016/03/22 20:41:32]

I spoke to the PM. We would like to know the number of times the user checks the
checkbox and goes on to complete the signin. So ideally, we would like to record
this action before/after signin_signin_withdefaultsyncsettings and
signin_signin_withadvancedsyncsettings to use in User Action Sequence graphs.
And also, we're not interested in knowing if they simply check/uncheck the
checkbox. I think the way the action is being recorded here achieves this goal.

[rkaplow, 2016/03/22 21:10:59]

I'm not sure I entirely agree. If you want to know how often people are checking
the checkbox, it's much better to have a baseline so you can understand the
number. Absolute counts are generally not as useful since it van vary with the
population - this is why we encourage all metrics to have baselines when
possible, and baselining by the number of times people complete the flow seems
natural.

You can leave the action you added so you can see what percentage of
withdefaultsyncsetting ended with the checkbox being checked for the sequenence
analyzer, but I think it would be better to also have a histogram which measures
what % of the time the checkbox is checked.

+  <owner>mahmadi@chromium.org</owner>
+  <description>
+    Recorded when the user checks the checkbox to be taken to the 'Activity
+    controls' section of the privacy settings page and chooses default or
+    advanced sync settings in the sign in succeed confirmation dialog.
+  </description>
+</action>
+
 <action name="Signin_Signin_WithAdvancedSyncSettings">
   <owner>gogerald@chromium.org</owner>
   <description>
     Recorded when the user chooses advanced sync settings in the sign in succeed
     confirmation dialog.
   </description>
 </action>
 
 <action name="Signin_Signin_WithDefaultSyncSettings">
   <owner>gogerald@chromium.org</owner>
@@ skipping 1359 matching lines @@
 <action name="webapps.AddShortcut.Manifest">
   <owner>mlamouri@chromium.org</owner>
   <description>
     Shortcut added to the homescreen with a valid Manifest. This action will be
     recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions
     to keep a trend of whether the webapp also add meta tags.
   </description>
 </action>
 
 </actions>