Enhanced Sync Confirmation modal

chrome/browser/ui/sync/one_click_signin_sync_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_sync_observer.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 10 matching lines @@
   content::WebContentsDelegate* tab_delegate = tab->GetDelegate();
   if (tab_delegate)
     tab_delegate->CloseContents(tab);
 }
 
 }  // namespace
 
 
 OneClickSigninSyncObserver::OneClickSigninSyncObserver(
     content::WebContents* web_contents,
+    Profile* profile,
+    Browser* browser,
+    const GURL& activity_controls_url,
     const GURL& continue_url)
     : content::WebContentsObserver(web_contents),
+      profile_(profile),
+      browser_(browser),
+      activity_controls_url_(activity_controls_url),
       continue_url_(continue_url),
       weak_ptr_factory_(this) {
-  DCHECK(!continue_url_.is_empty());
+  DCHECK(!continue_url_.is_empty() || !activity_controls_url.is_empty());

[Roger Tawa OOO till Jul 10th, 2016/03/23 01:14:15]

This DCHECK verifies that both URLs are not empty, but allow any one of them to
be empty.  Is that the desired behaviour?

[Moe, 2016/03/24 00:02:40]

Right now, OneClickSigninSyncObserver is used for navigating to the
|continue_url_| once Sync is initialized. My intention is to use it for
navigating to the |activity_controls_url| as well depending on which one is
passed in. Depending on where the observer is created, only one non-empty url is
passed in. I added a check in the if condition below to make sure we don't take
any action if the |continue_url| is empty.

also, in OneClickSigninSyncStarter::OnSyncConfirmationUIClosed web_content is
NULL, that's why I'm passing a Profile* to fetch the ProfileSyncService

 
   ProfileSyncService* sync_service = GetSyncService(web_contents);
   if (sync_service) {
     sync_service->AddObserver(this);
   } else {
     LoadContinueUrl();
     // Post a task rather than calling |delete this| here, so that the
     // destructor is not called directly from the constructor. Note that it's
     // important to pass a weak pointer rather than base::Unretained(this)
     // because it's possible for e.g. WebContentsDestroyed() to be called
@@ skipping 25 matching lines @@
     // Close the Gaia sign-in tab via a task to make sure we aren't in the
     // middle of any WebUI handler code.
     base::ThreadTaskRunnerHandle::Get()->PostTask(
         FROM_HERE, base::Bind(&CloseTab, base::Unretained(web_contents())));
   } else {
     if (sync_service->IsFirstSetupInProgress()) {
       // Sync setup has not completed yet. Wait for it to complete.
       return;
     }
 
+    if (!activity_controls_url_.is_empty()) {
+      // Open the 'Activity controls' section of the privacy settings.
+      content::OpenURLParams params(activity_controls_url_,
+                                    content::Referrer(),
+                                    NEW_FOREGROUND_TAB,
+                                    ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
+                                    false);
+      browser_->OpenURL(params);
+    }
+
     if (sync_service->IsSyncActive() &&
         signin::GetAccessPointForPromoURL(continue_url_) !=
             signin_metrics::AccessPoint::ACCESS_POINT_SETTINGS) {
       // TODO(isherman): Having multiple settings pages open can cause issues
       // redirecting after Sync is set up: http://crbug.com/355885
       LoadContinueUrl();
     }
   }
 
   sync_service->RemoveObserver(this);
   delete this;
 }
 
 void OneClickSigninSyncObserver::LoadContinueUrl() {
   web_contents()->GetController().LoadURL(
       continue_url_,
       content::Referrer(),
       ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
       std::string());
 }
 
 ProfileSyncService* OneClickSigninSyncObserver::GetSyncService(
     content::WebContents* web_contents) {
-  Profile* profile =
-      Profile::FromBrowserContext(web_contents->GetBrowserContext());
-  return ProfileSyncServiceFactory::GetForProfile(profile);
+  return ProfileSyncServiceFactory::GetForProfile(profile_);
 }
 
 // static
 void OneClickSigninSyncObserver::DeleteObserver(
     base::WeakPtr<OneClickSigninSyncObserver> observer) {
   if (observer)
     delete observer.get();
 }