Enhanced Sync Confirmation modal

chrome/browser/ui/sync/one_click_signin_sync_observer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_OBSERVER_H_
 #define CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_OBSERVER_H_
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
 #include "components/sync_driver/sync_service_observer.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "url/gurl.h"
 
 class ProfileSyncService;
 
 namespace content {
 class WebContents;
 }
 
 class OneClickSigninSyncObserver : public content::WebContentsObserver,
                                    public sync_driver::SyncServiceObserver {
  public:
-  // Waits for Sync to be initialized, then navigates the |web_contents| to the
-  // |continue_url|.  Instances of this class delete themselves once the job is
-  // done.
+  // Waits for the Sync for the |profile| to be initialized, then navigates the
+  // |web_contents| to the |continue_url| or opens |activity_controls_url| in
+  // a new browser tab depending on which one is provided. Instances of
+  // this class delete themselves once the job is done. |web_contents| may be
+  // NULL if only |activity_controls_url| is provided. Similarly |browser| may
+  // be NULL if only |continue_url| is provided.
   OneClickSigninSyncObserver(content::WebContents* web_contents,
+                             Profile* profile,
+                             Browser* browser,
+                             const GURL& activity_controls_url,
                              const GURL& continue_url);
 
  protected:
   // Exposed for testing.
   ~OneClickSigninSyncObserver() override;
 
  private:
   // content::WebContentsObserver:
   void WebContentsDestroyed() override;
 
   // sync_driver::SyncServiceObserver:
   void OnStateChanged() override;
 
   // Loads the |continue_url_| in the |web_contents()|.
   void LoadContinueUrl();
 
-  // Returns the ProfileSyncService associated with the |web_contents|.
+  // Returns the ProfileSyncService associated with the profile.
   // The returned value may be NULL.
-  ProfileSyncService* GetSyncService(content::WebContents* web_contents);
+  ProfileSyncService* GetSyncService();
 
   // Deletes the |observer|. Intended to be used as a callback for base::Bind.
   static void DeleteObserver(
       base::WeakPtr<OneClickSigninSyncObserver> observer);
 
+  Profile* profile_;
+
+  Browser* browser_;

[Dan Beam, 2016/04/04 23:48:38]

nit: arguably define the ownership here (i.e. // Weak reference.)

[Moe, 2016/04/05 17:14:42]

Done.

+
+  // The URL of the 'Activity controls' section of the privacy settings page.
+  const GURL activity_controls_url_;
+
   // The URL to redirect to once Sync is initialized.
   const GURL continue_url_;
 
   base::WeakPtrFactory<OneClickSigninSyncObserver> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OneClickSigninSyncObserver);
 };
 
 #endif  // CHROME_BROWSER_UI_SYNC_ONE_CLICK_SIGNIN_SYNC_OBSERVER_H_