Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1806333007: In start_try_job.GuessBisectBot, lower-case platform string. (Closed)

Created:
4 years, 9 months ago by qyearsley
Modified:
4 years, 9 months ago
Reviewers:
prasadv
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

In start_try_job.GuessBisectBot, lower-case platform string. In the case of Nexus 5X, it was checking whether the platform string "nexus5X" is in the lower-cased bot name "android-nexus5x". I believe the intent of lower-casing the bot name was to make the check case-insensitive; in order to do this, the platform string must also be lower-cased. https://bugs.chromium.org/p/chromium/issues/detail?id=595740 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/11b58109e296c868ab7f75551d8fdfda8e94d23e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M dashboard/dashboard/start_try_job.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
qyearsley
4 years, 9 months ago (2016-03-18 18:47:10 UTC) #2
prasadv
lgtm
4 years, 9 months ago (2016-03-18 18:55:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806333007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806333007/1
4 years, 9 months ago (2016-03-18 18:57:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/2039)
4 years, 9 months ago (2016-03-18 19:07:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806333007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806333007/1
4 years, 9 months ago (2016-03-18 19:42:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-18 22:30:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806333007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806333007/1
4 years, 9 months ago (2016-03-19 02:19:39 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 02:22:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698