Password manager on iOS should understand non-HTML landing pages

Password manager on iOS should understand non-HTML landing pages

Currently, password manager on iOS ignores all pages which are not HTML.
However, if a password form has a, e.g., text/plain landing page, this will
prevent password manager from saving a password on that form. This is
different from the desktop & Android behaviour.

This CL changes password manager on iOS, so that it considers all types of
landing pages, but unless these are HTML, does not try to find password forms
on them.

The test for the changed code is still downstream, and hence not in this CL.

BUG=595717
Committed: https://crrev.com/a0903eb6c26873d6d5e37ff0507dd695d54e25d3
Cr-Commit-Position: refs/heads/master@{#381949}

[vabr (Chromium), 2016-03-18 12:51:25]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-03-18 12:51:25]

Hi Vadym,

PTAL.

I'm working on the test downstream, but it will need some additional support in
WebTestWithWebController, so it will take longer. Will send you the test CL for
review, feel free to block or not on that.

Cheers,
Vaclav

[dvadym, 2016-03-18 13:04:55]

On 2016/03/18 12:51:25, vabr (Chromium) wrote:
> Hi Vadym,
> 
> PTAL.
> 
> I'm working on the test downstream, but it will need some additional support
in
> WebTestWithWebController, so it will take longer. Will send you the test CL
for
> review, feel free to block or not on that.
> 
> Cheers,
> Vaclav

Hi Vaclav, 

 LGTM, if it works in Chromium, I'm ok that test will be a little bit later,
since this change is very small and not risky.

[vabr (Chromium), 2016-03-18 13:09:41]

On 2016/03/18 13:04:55, dvadym wrote:
> On 2016/03/18 12:51:25, vabr (Chromium) wrote:
> > Hi Vadym,
> > 
> > PTAL.
> > 
> > I'm working on the test downstream, but it will need some additional support
> in
> > WebTestWithWebController, so it will take longer. Will send you the test CL
> for
> > review, feel free to block or not on that.
> > 
> > Cheers,
> > Vaclav
> 
> Hi Vaclav, 
> 
>  LGTM, if it works in Chromium, I'm ok that test will be a little bit later,
> since this change is very small and not risky.

Thanks, Vadym.

I indeed checked by running locally that this fixes the issue, and spot-checked
that other functionality looks unchanged.

I will land this now, and will continue working on the test.

Cheers,
Vaclav

[vabr (Chromium), 2016-03-18 13:13:23]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-03-18 13:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806333005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806333005/1

[commit-bot: I haz the power, 2016-03-18 13:21:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 13:22:14]

Description was changed from

==========
Password manager on iOS should understand non-HTML landing pages

Currently, password manager on iOS ignores all pages which are not HTML.
However, if a password form has a, e.g., text/plain landing page, this will
prevent password manager from saving a password on that form. This is
different from the desktop & Android behaviour.

This CL changes password manager on iOS, so that it considers all types of
landing pages, but unless these are HTML, does not try to find password forms
on them.

The test for the changed code is still downstream, and hence not in this CL.

BUG=595717
==========

to

==========
Password manager on iOS should understand non-HTML landing pages

Currently, password manager on iOS ignores all pages which are not HTML.
However, if a password form has a, e.g., text/plain landing page, this will
prevent password manager from saving a password on that form. This is
different from the desktop & Android behaviour.

This CL changes password manager on iOS, so that it considers all types of
landing pages, but unless these are HTML, does not try to find password forms
on them.

The test for the changed code is still downstream, and hence not in this CL.

BUG=595717

Committed: https://crrev.com/a0903eb6c26873d6d5e37ff0507dd695d54e25d3
Cr-Commit-Position: refs/heads/master@{#381949}
==========

[commit-bot: I haz the power, 2016-03-18 13:22:15]

Patchset 1 (id:??) landed as
https://crrev.com/a0903eb6c26873d6d5e37ff0507dd695d54e25d3
Cr-Commit-Position: refs/heads/master@{#381949}