Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 180633011: Rebaseline a few tests after VS2013 switch (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke, chrisphan
CC:
blink-reviews
Visibility:
Public.

Description

Rebaseline a few tests after VS2013 switch. Confirming that I can infact rebaseline tests. TBR=dpranke@chromium.org BUG=348800 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168400

Patch Set 1 #

Patch Set 2 : reitveld #

Patch Set 3 : reupload #

Patch Set 4 : remove linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/css2.1/20110323/replaced-min-max-001-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/css3/images/cross-fade-background-size-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/borders/border-image-repeat-expected.png View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
6 years, 9 months ago (2014-03-04 00:09:29 UTC) #1
Dirk Pranke
hmm, this diff doesn't look right, but it's been a while since I looked at ...
6 years, 9 months ago (2014-03-04 00:12:34 UTC) #2
scottmg
On 2014/03/04 00:12:34, Dirk Pranke wrote: > hmm, this diff doesn't look right, but it's ...
6 years, 9 months ago (2014-03-04 00:13:37 UTC) #3
scottmg
No linux now, I think this is reasonable, so going to land and start working ...
6 years, 9 months ago (2014-03-04 19:16:22 UTC) #4
scottmg
Committed patchset #4 manually as r168400 (presubmit successful).
6 years, 9 months ago (2014-03-04 19:17:21 UTC) #5
Dirk Pranke
6 years, 9 months ago (2014-03-04 19:17:44 UTC) #6
Message was sent while issue was closed.
much better. lgtm.

Powered by Google App Engine
This is Rietveld 408576698