content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc - Issue 180633008: Add different error codes for getUserMedia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

Issue 180633008: Add different error codes for getUserMedia. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed comments Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_dispatcher_host.cc ('K') | « content/browser/renderer_host/media/media_stream_dispatcher_host.cc ('k') | content/browser/renderer_host/media/media_stream_manager.h » ('j') | content/public/common/media_stream_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

index 4ebf35c6125b8e8dd8b3c0ff1b7ab121d6620fa5..5600278407be068663b4e9fab130d01efbd572b3 100644

--- a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

+++ b/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

@@ -148,7 +148,10 @@ class MockMediaStreamDispatcherHost : public MediaStreamDispatcherHost,

video_devices_ = video_device_list;

}

- void OnStreamGenerationFailed(const IPC::Message& msg, int request_id) {

+ void OnStreamGenerationFailed(

+ const IPC::Message& msg,

+ int request_id,

+ content::MediaStreamRequestResult result) {

OnStreamGenerationFailed(msg.routing_id(), request_id);

Tom Sepez 2014/03/06 18:36:26 nit: maybe pass |result| as well so it can be chec

Tommy Widenflycht 2014/03/07 11:50:05 Done.

if (!quit_closures_.empty()) {

base::Closure quit_closure = quit_closures_.front();