Add different error codes for getUserMedia.

Add different error codes for getUserMedia.
The spec now says that the error name is UA specific so I have now
Implemented a few different ones.
This patch is depending on a Blink Patch.

BUG=132812
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257081

[perkj_chrome, 2014-03-04 07:27:53]

Nice

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl.cc:586:
request_info->requestFailedUASpecific("PermissionDismissedError");
Should these strings ever be localized?

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl.cc:912: request_failed_ ?
content::TRACK_START_FAILURE : content::OK);
This can happen if the constraints are invalid or if the hardware fail to start.
It would be great if those two cases can be split up and also added to the
switch in CompleteGetUserMediaRequest(. Since the cl is pretty big anyway it
migh be worth doing in a separate cl. But please add this cause as a specific
error in CompleteGetUserMediaRequest.

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_impl_unittest.cc (right):

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl_unittest.cc:290:
FailToStartMockedVideoSource();
Expand this to also test the result value.

[Tommy Widenflycht, 2014-03-04 09:59:32]

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl.cc:586:
request_info->requestFailedUASpecific("PermissionDismissedError");
On 2014/03/04 07:27:54, perkj wrote:
> Should these strings ever be localized?

No, that would make it impossible to write apps that work world-wide.

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl.cc:912: request_failed_ ?
content::TRACK_START_FAILURE : content::OK);
On 2014/03/04 07:27:54, perkj wrote:
> This can happen if the constraints are invalid or if the hardware fail to
start.
> It would be great if those two cases can be split up and also added to the
> switch in CompleteGetUserMediaRequest(. Since the cl is pretty big anyway it
> migh be worth doing in a separate cl. But please add this cause as a specific
> error in CompleteGetUserMediaRequest.

Done.

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_impl_unittest.cc (right):

https://codereview.chromium.org/180633008/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl_unittest.cc:290:
FailToStartMockedVideoSource();
On 2014/03/04 07:27:54, perkj wrote:
> Expand this to also test the result value.

Done.

[perkj_chrome, 2014-03-04 13:35:52]

lgtm

[Tommy Widenflycht, 2014-03-05 07:49:56]

On 2014/03/04 13:35:52, perkj wrote:
> lgtm

vrk@ I need your OWNERS approval.

[tommi (sloooow) - chröme, 2014-03-05 14:11:27]

nice. lgtm!

[Tommy Widenflycht, 2014-03-05 14:17:59]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-05 14:18:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/20001

[commit-bot: I haz the power, 2014-03-05 14:30:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 14:30:54]

Try jobs failed on following builders: mac_chromium_compile_dbg

[Tommy Widenflycht, 2014-03-06 08:44:03]

yzshen@: Need OWNERS approval for content/renderer/pepper/
tsepez@: Need OWNERS approval for content/public/common/
joi@:  Need OWNERS approval for content/public/
sky@: Need OWNERS approval for content/browser/

[Jói, 2014-03-06 13:01:05]

//content/public LGTM.

[sky, 2014-03-06 16:44:48]

LGTM

[Tom Sepez, 2014-03-06 18:36:25]

Messages LGTM but a few drive-by comments.

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
File content/browser/renderer_host/media/media_stream_dispatcher_host.cc
(right):

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_dispatcher_host.cc:45: << ",
{page_request_id = " << page_request_id <<  "})";
nit: maybe log result here, too.

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
File
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:155:
OnStreamGenerationFailed(msg.routing_id(), request_id);
nit: maybe pass |result| as well so it can be checked in the mock method.

https://codereview.chromium.org/180633008/diff/20001/content/public/common/me...
File content/public/common/media_stream_request.h (right):

https://codereview.chromium.org/180633008/diff/20001/content/public/common/me...
content/public/common/media_stream_request.h:63: OK = 0,
nit:  are you sure we want to pollute the content namespace with a symbol like
|OK|?

[Tommy Widenflycht, 2014-03-07 11:50:04]

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
File content/browser/renderer_host/media/media_stream_dispatcher_host.cc
(right):

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_dispatcher_host.cc:45: << ",
{page_request_id = " << page_request_id <<  "})";
On 2014/03/06 18:36:26, Tom Sepez wrote:
> nit: maybe log result here, too.

Done.

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
File
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/180633008/diff/20001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:155:
OnStreamGenerationFailed(msg.routing_id(), request_id);
On 2014/03/06 18:36:26, Tom Sepez wrote:
> nit: maybe pass |result| as well so it can be checked in the mock method.

Done.

https://codereview.chromium.org/180633008/diff/20001/content/public/common/me...
File content/public/common/media_stream_request.h (right):

https://codereview.chromium.org/180633008/diff/20001/content/public/common/me...
content/public/common/media_stream_request.h:63: OK = 0,
On 2014/03/06 18:36:26, Tom Sepez wrote:
> nit:  are you sure we want to pollute the content namespace with a symbol like
> |OK|?

Not really... Fixed by prefixing with MEDIA_DEVICE_

[perkj_chrome, 2014-03-07 12:46:22]

SLGTM if the below nits are addressed.

https://codereview.chromium.org/180633008/diff/60001/content/browser/renderer...
File content/browser/renderer_host/media/media_stream_ui_proxy.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_ui_proxy.cc:222:
MEDIA_DEVICE_NO_HARDWARE :
4-space indentation

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl.cc:611: 
nit: remote extra space

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl.cc:916: MEDIA_DEVICE_OK);
fits on line above?

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
File content/renderer/media/media_stream_impl_unittest.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl_unittest.cc:62: state_ = result ==
MEDIA_DEVICE_OK ?
Please use parentheses and fix the indentation.

[Tommy Widenflycht, 2014-03-07 14:37:08]

https://codereview.chromium.org/180633008/diff/60001/content/browser/renderer...
File content/browser/renderer_host/media/media_stream_ui_proxy.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/browser/renderer...
content/browser/renderer_host/media/media_stream_ui_proxy.cc:222:
MEDIA_DEVICE_NO_HARDWARE :
On 2014/03/07 12:46:22, perkj wrote:
> 4-space indentation

Done.

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl.cc:611: 
On 2014/03/07 12:46:22, perkj wrote:
> nit: remote extra space

Done.

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl.cc:916: MEDIA_DEVICE_OK);
On 2014/03/07 12:46:22, perkj wrote:
> fits on line above?

Done.

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
File content/renderer/media/media_stream_impl_unittest.cc (right):

https://codereview.chromium.org/180633008/diff/60001/content/renderer/media/m...
content/renderer/media/media_stream_impl_unittest.cc:62: state_ = result ==
MEDIA_DEVICE_OK ?
On 2014/03/07 12:46:22, perkj wrote:
> Please use parentheses and fix the indentation.

Done.

[yzshen1, 2014-03-10 22:02:04]

(Sorry for late reply)

.*pepper.* LGTM

[Tommy Widenflycht, 2014-03-11 07:29:17]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-11 07:31:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/70001

[commit-bot: I haz the power, 2014-03-11 07:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 07:38:01]

Try jobs failed on following builders: linux_chromium_rel, mac_chromium_rel

[Tommy Widenflycht, 2014-03-11 08:42:43]

The CQ bit was unchecked by tommyw@chromium.org

[Tommy Widenflycht, 2014-03-11 08:42:44]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-11 08:44:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/70001

[commit-bot: I haz the power, 2014-03-11 09:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 09:42:38]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[Tommy Widenflycht, 2014-03-12 12:29:23]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-12 12:29:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/90001

[commit-bot: I haz the power, 2014-03-12 13:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:41:56]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Tommy Widenflycht, 2014-03-12 13:54:45]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-12 13:55:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/110001

[commit-bot: I haz the power, 2014-03-12 14:48:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 14:48:50]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[Tommy Widenflycht, 2014-03-12 15:29:20]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-12 15:31:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/130001

[commit-bot: I haz the power, 2014-03-12 16:59:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/130001

[commit-bot: I haz the power, 2014-03-12 17:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 17:24:40]

Try jobs failed on following builders: mac_chromium_rel

[Tommy Widenflycht, 2014-03-13 09:32:45]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-13 09:32:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/130001

[commit-bot: I haz the power, 2014-03-13 11:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 11:01:58]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[tommi (sloooow) - chröme, 2014-03-13 14:18:04]

lgtm % style issues

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
File
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:412:
kRenderId,
fix indent

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:641:
kRenderId,
indent

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_stream_manager.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_manager.cc:1556: if
(!SetupDeviceCaptureRequest(request))
can you fix this if/else to use braces now that it has multiple lines?

https://codereview.chromium.org/180633008/diff/150001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:1592:
callback.Run(MediaStreamDevices(),
add braces to if/else

https://codereview.chromium.org/180633008/diff/150001/content/renderer/media/...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/renderer/media/...
content/renderer/media/media_stream_impl.cc:912: if (!ready_callback_.is_null()
&& sources_waiting_for_callback_.empty())
{}

[Tommy Widenflycht, 2014-03-13 15:43:49]

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
File
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
(right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:412:
kRenderId,
On 2014/03/13 14:18:05, tommi wrote:
> fix indent

Done.

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc:641:
kRenderId,
On 2014/03/13 14:18:05, tommi wrote:
> indent

Done.

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
File content/browser/renderer_host/media/media_stream_manager.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/rendere...
content/browser/renderer_host/media/media_stream_manager.cc:1556: if
(!SetupDeviceCaptureRequest(request))
On 2014/03/13 14:18:05, tommi wrote:
> can you fix this if/else to use braces now that it has multiple lines?

Done.

https://codereview.chromium.org/180633008/diff/150001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/browser/web_con...
content/browser/web_contents/web_contents_impl.cc:1592:
callback.Run(MediaStreamDevices(),
On 2014/03/13 14:18:05, tommi wrote:
> add braces to if/else

Done.

https://codereview.chromium.org/180633008/diff/150001/content/renderer/media/...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/180633008/diff/150001/content/renderer/media/...
content/renderer/media/media_stream_impl.cc:912: if (!ready_callback_.is_null()
&& sources_waiting_for_callback_.empty())
On 2014/03/13 14:18:05, tommi wrote:
> {}

Done.

[Tommy Widenflycht, 2014-03-13 17:37:04]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-13 17:39:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/160001

[commit-bot: I haz the power, 2014-03-13 23:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 23:37:30]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Tommy Widenflycht, 2014-03-14 08:27:29]

The CQ bit was checked by tommyw@chromium.org

[commit-bot: I haz the power, 2014-03-14 08:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tommyw@chromium.org/180633008/160001

[commit-bot: I haz the power, 2014-03-14 11:52:42]

Change committed as 257081