content/browser/renderer_host/media/audio_renderer_host_unittest.cc - Issue 1806313003: Pass task runners to AudioManager constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from patch 48 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/audio_renderer_host.cc ('k') | content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

diff --git a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

index a0cdfdb4dafea0c650105473b642152f361f5a8e..467e2be3645b9d8010a85a3cb2654f10efc9873c 100644

--- a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

+++ b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc

@@ -187,7 +187,8 @@ void WaitForEnumeration(base::RunLoop* loop,

class AudioRendererHostTest : public testing::Test {

public:

AudioRendererHostTest() {

- audio_manager_.reset(media::AudioManager::CreateForTesting());

+ audio_manager_ = media::AudioManager::CreateForTesting(

+ base::ThreadTaskRunnerHandle::Get());

base::CommandLine::ForCurrentProcess()->AppendSwitch(

switches::kUseFakeDeviceForMediaStream);

media_stream_manager_.reset(new MediaStreamManager(audio_manager_.get()));

@@ -328,7 +329,7 @@ class AudioRendererHostTest : public testing::Test {

// TestBrowserThreadBundle.

std::unique_ptr<MediaStreamManager> media_stream_manager_;

TestBrowserThreadBundle thread_bundle_;

- std::unique_ptr<media::AudioManager> audio_manager_;

+ media::ScopedAudioManagerPtr audio_manager_;

MockAudioMirroringManager mirroring_manager_;

scoped_refptr<MockAudioRendererHost> host_;