chromecast/media/audio/cast_audio_manager_factory.h - Issue 1806313003: Pass task runners to AudioManager constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/audio/cast_audio_manager_factory.h

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments from patch 48 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/audio/cast_audio_manager_factory.h

diff --git a/chromecast/media/audio/cast_audio_manager_factory.h b/chromecast/media/audio/cast_audio_manager_factory.h

index 627a68dd991e197e8c48d50cfbb68e96d8287a40..d80cc840853d290284b08fe7a2df6df8426e2d1b 100644

--- a/chromecast/media/audio/cast_audio_manager_factory.h

+++ b/chromecast/media/audio/cast_audio_manager_factory.h

@@ -20,8 +20,10 @@ class CastAudioManagerFactory : public ::media::AudioManagerFactory {

~CastAudioManagerFactory() override;

// ::media::AudioManagerFactory overrides.

- ::media::AudioManager* CreateInstance(

- ::media::AudioLogFactory* audio_log_factory) override;

+ scoped_ptr<::media::AudioManager, ::media::AudioManagerDeleter>

+ CreateInstance(scoped_refptr<base::SingleThreadTaskRunner> task_runner,

+ scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,

+ ::media::AudioLogFactory* audio_log_factory) override;

private:

MediaPipelineBackendManager* const backend_manager_;