Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: media/audio/sounds/sounds_manager_unittest.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from patch 48 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h"
11 #include "base/message_loop/message_loop.h"
12 #include "base/run_loop.h" 10 #include "base/run_loop.h"
13 #include "base/strings/string_piece.h" 11 #include "base/strings/string_piece.h"
12 #include "base/test/test_message_loop.h"
13 #include "base/thread_task_runner_handle.h"
14 #include "media/audio/audio_manager.h" 14 #include "media/audio/audio_manager.h"
15 #include "media/audio/simple_sources.h" 15 #include "media/audio/simple_sources.h"
16 #include "media/audio/sounds/audio_stream_handler.h" 16 #include "media/audio/sounds/audio_stream_handler.h"
17 #include "media/audio/sounds/sounds_manager.h" 17 #include "media/audio/sounds/sounds_manager.h"
18 #include "media/audio/sounds/test_data.h" 18 #include "media/audio/sounds/test_data.h"
19 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
20 20
21 namespace media { 21 namespace media {
22 22
23 class SoundsManagerTest : public testing::Test { 23 class SoundsManagerTest : public testing::Test {
24 public: 24 public:
25 SoundsManagerTest() {} 25 SoundsManagerTest() {}
26 ~SoundsManagerTest() override {} 26 ~SoundsManagerTest() override {}
27 27
28 void SetUp() override { 28 void SetUp() override {
29 audio_manager_.reset(AudioManager::CreateForTesting()); 29 audio_manager_ =
30 AudioManager::CreateForTesting(base::ThreadTaskRunnerHandle::Get());
30 SoundsManager::Create(); 31 SoundsManager::Create();
32 base::RunLoop().RunUntilIdle();
31 } 33 }
32 34
33 void TearDown() override { 35 void TearDown() override {
34 SoundsManager::Shutdown(); 36 SoundsManager::Shutdown();
35 audio_manager_.reset(); 37 base::RunLoop().RunUntilIdle();
36 } 38 }
37 39
38 void SetObserverForTesting(AudioStreamHandler::TestObserver* observer) { 40 void SetObserverForTesting(AudioStreamHandler::TestObserver* observer) {
39 AudioStreamHandler::SetObserverForTesting(observer); 41 AudioStreamHandler::SetObserverForTesting(observer);
40 } 42 }
41 43
42 void SetAudioSourceForTesting( 44 void SetAudioSourceForTesting(
43 AudioOutputStream::AudioSourceCallback* source) { 45 AudioOutputStream::AudioSourceCallback* source) {
44 AudioStreamHandler::SetAudioSourceForTesting(source); 46 AudioStreamHandler::SetAudioSourceForTesting(source);
45 } 47 }
46 48
47 private: 49 private:
48 scoped_ptr<AudioManager> audio_manager_; 50 base::TestMessageLoop message_loop_;
49 51 ScopedAudioManagerPtr audio_manager_;
50 base::MessageLoop message_loop_;
51 }; 52 };
52 53
53 TEST_F(SoundsManagerTest, Play) { 54 TEST_F(SoundsManagerTest, Play) {
54 ASSERT_TRUE(SoundsManager::Get()); 55 ASSERT_TRUE(SoundsManager::Get());
55 56
56 base::RunLoop run_loop; 57 base::RunLoop run_loop;
57 TestObserver observer(run_loop.QuitClosure()); 58 TestObserver observer(run_loop.QuitClosure());
58 59
59 SetObserverForTesting(&observer); 60 SetObserverForTesting(&observer);
60 61
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 SetObserverForTesting(NULL); 107 SetObserverForTesting(NULL);
107 } 108 }
108 109
109 TEST_F(SoundsManagerTest, Uninitialized) { 110 TEST_F(SoundsManagerTest, Uninitialized) {
110 ASSERT_TRUE(SoundsManager::Get()); 111 ASSERT_TRUE(SoundsManager::Get());
111 ASSERT_FALSE(SoundsManager::Get()->Play(kTestAudioKey)); 112 ASSERT_FALSE(SoundsManager::Get()->Play(kTestAudioKey));
112 ASSERT_FALSE(SoundsManager::Get()->Stop(kTestAudioKey)); 113 ASSERT_FALSE(SoundsManager::Get()->Stop(kTestAudioKey));
113 } 114 }
114 115
115 } // namespace media 116 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/sounds/audio_stream_handler_unittest.cc ('k') | media/audio/win/audio_low_latency_input_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698