Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: media/audio/audio_input_controller_unittest.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments from patch 48 Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_input_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/synchronization/waitable_event.h" 8 #include "base/synchronization/waitable_event.h"
9 #include "base/test/test_timeouts.h" 9 #include "base/test/test_timeouts.h"
10 #include "media/audio/audio_input_controller.h" 10 #include "media/audio/audio_input_controller.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void(AudioInputController* controller, 60 void(AudioInputController* controller,
61 const std::string& message)); 61 const std::string& message));
62 62
63 private: 63 private:
64 DISALLOW_COPY_AND_ASSIGN(MockAudioInputControllerEventHandler); 64 DISALLOW_COPY_AND_ASSIGN(MockAudioInputControllerEventHandler);
65 }; 65 };
66 66
67 // Test fixture. 67 // Test fixture.
68 class AudioInputControllerTest : public testing::Test { 68 class AudioInputControllerTest : public testing::Test {
69 public: 69 public:
70 AudioInputControllerTest() {} 70 AudioInputControllerTest()
71 ~AudioInputControllerTest() override {} 71 : audio_manager_(
72 AudioManager::CreateForTesting(message_loop_.task_runner())) {
73 // Flush the message loop to ensure that AudioManager is fully initialized.
74 message_loop_.RunUntilIdle();
75 }
76 ~AudioInputControllerTest() override {
77 audio_manager_.reset();
78 message_loop_.RunUntilIdle();
79 }
72 80
73 protected: 81 protected:
74 base::MessageLoop message_loop_; 82 base::MessageLoop message_loop_;
83 ScopedAudioManagerPtr audio_manager_;
75 84
76 private: 85 private:
77 DISALLOW_COPY_AND_ASSIGN(AudioInputControllerTest); 86 DISALLOW_COPY_AND_ASSIGN(AudioInputControllerTest);
78 }; 87 };
79 88
80 // Test AudioInputController for create and close without recording audio. 89 // Test AudioInputController for create and close without recording audio.
81 TEST_F(AudioInputControllerTest, CreateAndClose) { 90 TEST_F(AudioInputControllerTest, CreateAndClose) {
82 MockAudioInputControllerEventHandler event_handler; 91 MockAudioInputControllerEventHandler event_handler;
83 92
84 // OnCreated() will be posted once. 93 // OnCreated() will be posted once.
85 EXPECT_CALL(event_handler, OnCreated(NotNull())) 94 EXPECT_CALL(event_handler, OnCreated(NotNull()))
86 .WillOnce(QuitMessageLoop(&message_loop_)); 95 .WillOnce(QuitMessageLoop(&message_loop_));
87 96
88 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
89 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 97 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
90 kSampleRate, kBitsPerSample, kSamplesPerPacket); 98 kSampleRate, kBitsPerSample, kSamplesPerPacket);
91 99
92 scoped_refptr<AudioInputController> controller = 100 scoped_refptr<AudioInputController> controller =
93 AudioInputController::Create(audio_manager.get(), 101 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
94 &event_handler, 102 AudioManagerBase::kDefaultDeviceId, NULL);
95 params,
96 AudioManagerBase::kDefaultDeviceId,
97 NULL);
98 ASSERT_TRUE(controller.get()); 103 ASSERT_TRUE(controller.get());
99 104
100 // Wait for OnCreated() to fire. 105 // Wait for OnCreated() to fire.
101 message_loop_.Run(); 106 message_loop_.Run();
102 107
103 // Close the AudioInputController synchronously. 108 // Close the AudioInputController synchronously.
104 CloseAudioController(controller.get()); 109 CloseAudioController(controller.get());
105 } 110 }
106 111
107 // Test a normal call sequence of create, record and close. 112 // Test a normal call sequence of create, record and close.
108 TEST_F(AudioInputControllerTest, RecordAndClose) { 113 TEST_F(AudioInputControllerTest, RecordAndClose) {
109 MockAudioInputControllerEventHandler event_handler; 114 MockAudioInputControllerEventHandler event_handler;
110 int count = 0; 115 int count = 0;
111 116
112 // OnCreated() will be called once. 117 // OnCreated() will be called once.
113 EXPECT_CALL(event_handler, OnCreated(NotNull())) 118 EXPECT_CALL(event_handler, OnCreated(NotNull()))
114 .Times(Exactly(1)); 119 .Times(Exactly(1));
115 120
116 // OnRecording() will be called only once. 121 // OnRecording() will be called only once.
117 EXPECT_CALL(event_handler, OnRecording(NotNull())) 122 EXPECT_CALL(event_handler, OnRecording(NotNull()))
118 .Times(Exactly(1)); 123 .Times(Exactly(1));
119 124
120 // OnData() shall be called ten times. 125 // OnData() shall be called ten times.
121 EXPECT_CALL(event_handler, OnData(NotNull(), NotNull())) 126 EXPECT_CALL(event_handler, OnData(NotNull(), NotNull()))
122 .Times(AtLeast(10)) 127 .Times(AtLeast(10))
123 .WillRepeatedly(CheckCountAndPostQuitTask( 128 .WillRepeatedly(CheckCountAndPostQuitTask(
124 &count, 10, message_loop_.task_runner())); 129 &count, 10, message_loop_.task_runner()));
125 130
126 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
127 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 131 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
128 kSampleRate, kBitsPerSample, kSamplesPerPacket); 132 kSampleRate, kBitsPerSample, kSamplesPerPacket);
129 133
130 // Creating the AudioInputController should render an OnCreated() call. 134 // Creating the AudioInputController should render an OnCreated() call.
131 scoped_refptr<AudioInputController> controller = 135 scoped_refptr<AudioInputController> controller =
132 AudioInputController::Create(audio_manager.get(), 136 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
133 &event_handler, 137 AudioManagerBase::kDefaultDeviceId, NULL);
134 params,
135 AudioManagerBase::kDefaultDeviceId,
136 NULL);
137 ASSERT_TRUE(controller.get()); 138 ASSERT_TRUE(controller.get());
138 139
139 // Start recording and trigger one OnRecording() call. 140 // Start recording and trigger one OnRecording() call.
140 controller->Record(); 141 controller->Record();
141 142
142 // Record and wait until ten OnData() callbacks are received. 143 // Record and wait until ten OnData() callbacks are received.
143 message_loop_.Run(); 144 message_loop_.Run();
144 145
145 // Close the AudioInputController synchronously. 146 // Close the AudioInputController synchronously.
146 CloseAudioController(controller.get()); 147 CloseAudioController(controller.get());
(...skipping 22 matching lines...) Expand all
169 .WillRepeatedly(CheckCountAndPostQuitTask( 170 .WillRepeatedly(CheckCountAndPostQuitTask(
170 &count, 10, message_loop_.task_runner())); 171 &count, 10, message_loop_.task_runner()));
171 172
172 // OnError() will be called after the data stream stops while the 173 // OnError() will be called after the data stream stops while the
173 // controller is in a recording state. 174 // controller is in a recording state.
174 EXPECT_CALL(event_handler, OnError(NotNull(), 175 EXPECT_CALL(event_handler, OnError(NotNull(),
175 AudioInputController::NO_DATA_ERROR)) 176 AudioInputController::NO_DATA_ERROR))
176 .Times(Exactly(1)) 177 .Times(Exactly(1))
177 .WillOnce(QuitMessageLoop(&message_loop_)); 178 .WillOnce(QuitMessageLoop(&message_loop_));
178 179
179 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
180 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 180 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
181 kSampleRate, kBitsPerSample, kSamplesPerPacket); 181 kSampleRate, kBitsPerSample, kSamplesPerPacket);
182 182
183 // Creating the AudioInputController should render an OnCreated() call. 183 // Creating the AudioInputController should render an OnCreated() call.
184 scoped_refptr<AudioInputController> controller = 184 scoped_refptr<AudioInputController> controller =
185 AudioInputController::Create(audio_manager.get(), 185 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
186 &event_handler, 186 AudioManagerBase::kDefaultDeviceId, NULL);
187 params,
188 AudioManagerBase::kDefaultDeviceId,
189 NULL);
190 ASSERT_TRUE(controller.get()); 187 ASSERT_TRUE(controller.get());
191 188
192 // Start recording and trigger one OnRecording() call. 189 // Start recording and trigger one OnRecording() call.
193 controller->Record(); 190 controller->Record();
194 191
195 // Record and wait until ten OnData() callbacks are received. 192 // Record and wait until ten OnData() callbacks are received.
196 message_loop_.Run(); 193 message_loop_.Run();
197 194
198 // Stop the stream and verify that OnError() is posted. 195 // Stop the stream and verify that OnError() is posted.
199 AudioInputStream* stream = controller->stream_for_testing(); 196 AudioInputStream* stream = controller->stream_for_testing();
200 stream->Stop(); 197 stream->Stop();
201 message_loop_.Run(); 198 message_loop_.Run();
202 199
203 // Close the AudioInputController synchronously. 200 // Close the AudioInputController synchronously.
204 CloseAudioController(controller.get()); 201 CloseAudioController(controller.get());
205 } 202 }
206 203
207 // Test that AudioInputController rejects insanely large packet sizes. 204 // Test that AudioInputController rejects insanely large packet sizes.
208 TEST_F(AudioInputControllerTest, SamplesPerPacketTooLarge) { 205 TEST_F(AudioInputControllerTest, SamplesPerPacketTooLarge) {
209 // Create an audio device with a very large packet size. 206 // Create an audio device with a very large packet size.
210 MockAudioInputControllerEventHandler event_handler; 207 MockAudioInputControllerEventHandler event_handler;
211 208
212 // OnCreated() shall not be called in this test. 209 // OnCreated() shall not be called in this test.
213 EXPECT_CALL(event_handler, OnCreated(NotNull())) 210 EXPECT_CALL(event_handler, OnCreated(NotNull()))
214 .Times(Exactly(0)); 211 .Times(Exactly(0));
215 212
216 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
217 AudioParameters params(AudioParameters::AUDIO_FAKE, 213 AudioParameters params(AudioParameters::AUDIO_FAKE,
218 kChannelLayout, 214 kChannelLayout,
219 kSampleRate, 215 kSampleRate,
220 kBitsPerSample, 216 kBitsPerSample,
221 kSamplesPerPacket * 1000); 217 kSamplesPerPacket * 1000);
222 scoped_refptr<AudioInputController> controller = 218 scoped_refptr<AudioInputController> controller =
223 AudioInputController::Create(audio_manager.get(), 219 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
224 &event_handler, 220 AudioManagerBase::kDefaultDeviceId, NULL);
225 params,
226 AudioManagerBase::kDefaultDeviceId,
227 NULL);
228 ASSERT_FALSE(controller.get()); 221 ASSERT_FALSE(controller.get());
229 } 222 }
230 223
231 // Test calling AudioInputController::Close multiple times. 224 // Test calling AudioInputController::Close multiple times.
232 TEST_F(AudioInputControllerTest, CloseTwice) { 225 TEST_F(AudioInputControllerTest, CloseTwice) {
233 MockAudioInputControllerEventHandler event_handler; 226 MockAudioInputControllerEventHandler event_handler;
234 227
235 // OnRecording() will be called only once. 228 // OnRecording() will be called only once.
236 EXPECT_CALL(event_handler, OnCreated(NotNull())); 229 EXPECT_CALL(event_handler, OnCreated(NotNull()));
237 230
238 // OnRecording() will be called only once. 231 // OnRecording() will be called only once.
239 EXPECT_CALL(event_handler, OnRecording(NotNull())) 232 EXPECT_CALL(event_handler, OnRecording(NotNull()))
240 .Times(Exactly(1)); 233 .Times(Exactly(1));
241 234
242 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
243 AudioParameters params(AudioParameters::AUDIO_FAKE, 235 AudioParameters params(AudioParameters::AUDIO_FAKE,
244 kChannelLayout, 236 kChannelLayout,
245 kSampleRate, 237 kSampleRate,
246 kBitsPerSample, 238 kBitsPerSample,
247 kSamplesPerPacket); 239 kSamplesPerPacket);
248 scoped_refptr<AudioInputController> controller = 240 scoped_refptr<AudioInputController> controller =
249 AudioInputController::Create(audio_manager.get(), 241 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
250 &event_handler, 242 AudioManagerBase::kDefaultDeviceId, NULL);
251 params,
252 AudioManagerBase::kDefaultDeviceId,
253 NULL);
254 ASSERT_TRUE(controller.get()); 243 ASSERT_TRUE(controller.get());
255 244
256 controller->Record(); 245 controller->Record();
257 246
258 controller->Close(base::MessageLoop::QuitWhenIdleClosure()); 247 controller->Close(base::MessageLoop::QuitWhenIdleClosure());
259 base::MessageLoop::current()->Run(); 248 base::MessageLoop::current()->Run();
260 249
261 controller->Close(base::MessageLoop::QuitWhenIdleClosure()); 250 controller->Close(base::MessageLoop::QuitWhenIdleClosure());
262 base::MessageLoop::current()->Run(); 251 base::MessageLoop::current()->Run();
263 } 252 }
264 253
265 } // namespace media 254 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_input_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698