Pass task runners to AudioManager constructor.

media/audio/linux/audio_manager_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
+#include "media/audio/audio_thread.h"
+#include "media/base/media_switches.h"
+
 #if defined(USE_ALSA)
 #include "media/audio/alsa/audio_manager_alsa.h"
 #else
 #include "media/audio/fake_audio_manager.h"
 #endif
 #if defined(USE_CRAS)
 #include "media/audio/cras/audio_manager_cras.h"
 #endif
 #if defined(USE_PULSEAUDIO)
 #include "media/audio/pulse/audio_manager_pulse.h"
 #endif
-#include "media/base/media_switches.h"
 
 namespace media {
 
 enum LinuxAudioIO {
   kPulse,
   kAlsa,
   kCras,
   kAudioIOMax = kCras  // Must always be equal to largest logged entry.
 };
 
-AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) {
+AudioManager* CreateAudioManager(

[DaleCurtis, 2016/03/18 17:48:19]

It'd be nice if the default Create() function handled sorting this out instead
of copy/pasting the same logic for all classes.

[alokp, 2016/03/18 18:40:07]

I did not not do that because I wanted to use a different default task runner
for Cast. But we can avoid that by adding
ContentBrowserClient::GetAudioTaskRunner.

+    const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
+    const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner,
+    AudioLogFactory* audio_log_factory) {
+  scoped_refptr<base::SingleThreadTaskRunner> audio_runner =
+      task_runner ? task_runner : AudioThread::Get()->task_runner();
+  scoped_refptr<base::SingleThreadTaskRunner> worker_runner =
+      worker_task_runner ? worker_task_runner
+                         : AudioThread::Get()->task_runner();
+
 #if defined(USE_CRAS)
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) {
     UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1);
-    return new AudioManagerCras(audio_log_factory);
+    return new AudioManagerCras(audio_runner, worker_runner, audio_log_factory);
   }
 #endif
 
 #if defined(USE_PULSEAUDIO)
-  AudioManager* manager = AudioManagerPulse::Create(audio_log_factory);
-  if (manager) {
+  scoped_ptr<AudioManagerPulse> manager(
+      new AudioManagerPulse(audio_runner, worker_runner, audio_log_factory));
+  if (manager->Init()) {
     UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1);
-    return manager;
+    return manager.release();
+  } else {
+    DVLOG(1) << "PulseAudio is not available on the OS";
+    AudioManager::Destroy(manager.release());
   }
 #endif
 
 #if defined(USE_ALSA)
   UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1);
-  return new AudioManagerAlsa(audio_log_factory);
+  return new AudioManagerAlsa(audio_runner, worker_runner, audio_log_factory);
 #else
-  return new FakeAudioManager(audio_log_factory);
+  return new FakeAudioManager(audio_runner, worker_runner, audio_log_factory);
 #endif
 }
 
 }  // namespace media