Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: media/audio/linux/audio_manager_linux.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: destroy AudioManagerPulse Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/metrics/histogram.h" 6 #include "base/metrics/histogram.h"
7 #include "media/audio/audio_thread.h"
8 #include "media/base/media_switches.h"
9
7 #if defined(USE_ALSA) 10 #if defined(USE_ALSA)
8 #include "media/audio/alsa/audio_manager_alsa.h" 11 #include "media/audio/alsa/audio_manager_alsa.h"
9 #else 12 #else
10 #include "media/audio/fake_audio_manager.h" 13 #include "media/audio/fake_audio_manager.h"
11 #endif 14 #endif
12 #if defined(USE_CRAS) 15 #if defined(USE_CRAS)
13 #include "media/audio/cras/audio_manager_cras.h" 16 #include "media/audio/cras/audio_manager_cras.h"
14 #endif 17 #endif
15 #if defined(USE_PULSEAUDIO) 18 #if defined(USE_PULSEAUDIO)
16 #include "media/audio/pulse/audio_manager_pulse.h" 19 #include "media/audio/pulse/audio_manager_pulse.h"
17 #endif 20 #endif
18 #include "media/base/media_switches.h"
19 21
20 namespace media { 22 namespace media {
21 23
22 enum LinuxAudioIO { 24 enum LinuxAudioIO {
23 kPulse, 25 kPulse,
24 kAlsa, 26 kAlsa,
25 kCras, 27 kCras,
26 kAudioIOMax = kCras // Must always be equal to largest logged entry. 28 kAudioIOMax = kCras // Must always be equal to largest logged entry.
27 }; 29 };
28 30
29 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) { 31 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) {
32 base::Thread* audio_thread = AudioThread::Get();
33
30 #if defined(USE_CRAS) 34 #if defined(USE_CRAS)
31 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) { 35 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) {
32 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1); 36 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1);
33 return new AudioManagerCras(audio_log_factory); 37 return new AudioManagerCras(audio_thread->task_runner(),
38 audio_thread->task_runner(), audio_log_factory);
34 } 39 }
35 #endif 40 #endif
36 41
37 #if defined(USE_PULSEAUDIO) 42 #if defined(USE_PULSEAUDIO)
38 AudioManager* manager = AudioManagerPulse::Create(audio_log_factory); 43 scoped_ptr<AudioManagerPulse> manager(
39 if (manager) { 44 new AudioManagerPulse(audio_thread->task_runner(),
45 audio_thread->task_runner(), audio_log_factory));
46 if (manager->Init()) {
40 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1); 47 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1);
41 return manager; 48 return manager.release();
49 } else {
50 DVLOG(1) << "PulseAudio is not available on the OS";
51 AudioManager::Destroy(manager.release());
42 } 52 }
43 #endif 53 #endif
44 54
45 #if defined(USE_ALSA) 55 #if defined(USE_ALSA)
46 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1); 56 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1);
47 return new AudioManagerAlsa(audio_log_factory); 57 return new AudioManagerAlsa(audio_thread->task_runner(),
58 audio_thread->task_runner(), audio_log_factory);
48 #else 59 #else
49 return new FakeAudioManager(audio_log_factory); 60 return new FakeAudioManager(audio_thread->task_runner(),
61 audio_thread->task_runner(), audio_log_factory);
50 #endif 62 #endif
51 } 63 }
52 64
53 } // namespace media 65 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698