Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: media/audio/audio_input_controller_unittest.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: destroy AudioManagerPulse Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/macros.h" 6 #include "base/macros.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/synchronization/waitable_event.h" 8 #include "base/synchronization/waitable_event.h"
9 #include "base/test/test_timeouts.h" 9 #include "base/test/test_timeouts.h"
10 #include "media/audio/audio_input_controller.h" 10 #include "media/audio/audio_input_controller.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 void(AudioInputController* controller, 60 void(AudioInputController* controller,
61 const std::string& message)); 61 const std::string& message));
62 62
63 private: 63 private:
64 DISALLOW_COPY_AND_ASSIGN(MockAudioInputControllerEventHandler); 64 DISALLOW_COPY_AND_ASSIGN(MockAudioInputControllerEventHandler);
65 }; 65 };
66 66
67 // Test fixture. 67 // Test fixture.
68 class AudioInputControllerTest : public testing::Test { 68 class AudioInputControllerTest : public testing::Test {
69 public: 69 public:
70 AudioInputControllerTest() {} 70 AudioInputControllerTest()
71 ~AudioInputControllerTest() override {} 71 : audio_manager_(AudioManager::CreateForTesting()) {}
72 ~AudioInputControllerTest() override {
73 AudioManager::Destroy(audio_manager_.release());
74 }
72 75
73 protected: 76 protected:
74 base::MessageLoop message_loop_; 77 base::MessageLoop message_loop_;
78 scoped_ptr<AudioManager> audio_manager_;
75 79
76 private: 80 private:
77 DISALLOW_COPY_AND_ASSIGN(AudioInputControllerTest); 81 DISALLOW_COPY_AND_ASSIGN(AudioInputControllerTest);
78 }; 82 };
79 83
80 // Test AudioInputController for create and close without recording audio. 84 // Test AudioInputController for create and close without recording audio.
81 TEST_F(AudioInputControllerTest, CreateAndClose) { 85 TEST_F(AudioInputControllerTest, CreateAndClose) {
82 MockAudioInputControllerEventHandler event_handler; 86 MockAudioInputControllerEventHandler event_handler;
83 87
84 // OnCreated() will be posted once. 88 // OnCreated() will be posted once.
85 EXPECT_CALL(event_handler, OnCreated(NotNull())) 89 EXPECT_CALL(event_handler, OnCreated(NotNull()))
86 .WillOnce(QuitMessageLoop(&message_loop_)); 90 .WillOnce(QuitMessageLoop(&message_loop_));
87 91
88 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
89 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 92 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
90 kSampleRate, kBitsPerSample, kSamplesPerPacket); 93 kSampleRate, kBitsPerSample, kSamplesPerPacket);
91 94
92 scoped_refptr<AudioInputController> controller = 95 scoped_refptr<AudioInputController> controller =
93 AudioInputController::Create(audio_manager.get(), 96 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
94 &event_handler, 97 AudioManagerBase::kDefaultDeviceId, NULL);
95 params,
96 AudioManagerBase::kDefaultDeviceId,
97 NULL);
98 ASSERT_TRUE(controller.get()); 98 ASSERT_TRUE(controller.get());
99 99
100 // Wait for OnCreated() to fire. 100 // Wait for OnCreated() to fire.
101 message_loop_.Run(); 101 message_loop_.Run();
102 102
103 // Close the AudioInputController synchronously. 103 // Close the AudioInputController synchronously.
104 CloseAudioController(controller.get()); 104 CloseAudioController(controller.get());
105 } 105 }
106 106
107 // Test a normal call sequence of create, record and close. 107 // Test a normal call sequence of create, record and close.
108 TEST_F(AudioInputControllerTest, RecordAndClose) { 108 TEST_F(AudioInputControllerTest, RecordAndClose) {
109 MockAudioInputControllerEventHandler event_handler; 109 MockAudioInputControllerEventHandler event_handler;
110 int count = 0; 110 int count = 0;
111 111
112 // OnCreated() will be called once. 112 // OnCreated() will be called once.
113 EXPECT_CALL(event_handler, OnCreated(NotNull())) 113 EXPECT_CALL(event_handler, OnCreated(NotNull()))
114 .Times(Exactly(1)); 114 .Times(Exactly(1));
115 115
116 // OnRecording() will be called only once. 116 // OnRecording() will be called only once.
117 EXPECT_CALL(event_handler, OnRecording(NotNull())) 117 EXPECT_CALL(event_handler, OnRecording(NotNull()))
118 .Times(Exactly(1)); 118 .Times(Exactly(1));
119 119
120 // OnData() shall be called ten times. 120 // OnData() shall be called ten times.
121 EXPECT_CALL(event_handler, OnData(NotNull(), NotNull())) 121 EXPECT_CALL(event_handler, OnData(NotNull(), NotNull()))
122 .Times(AtLeast(10)) 122 .Times(AtLeast(10))
123 .WillRepeatedly(CheckCountAndPostQuitTask( 123 .WillRepeatedly(CheckCountAndPostQuitTask(
124 &count, 10, message_loop_.task_runner())); 124 &count, 10, message_loop_.task_runner()));
125 125
126 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
127 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 126 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
128 kSampleRate, kBitsPerSample, kSamplesPerPacket); 127 kSampleRate, kBitsPerSample, kSamplesPerPacket);
129 128
130 // Creating the AudioInputController should render an OnCreated() call. 129 // Creating the AudioInputController should render an OnCreated() call.
131 scoped_refptr<AudioInputController> controller = 130 scoped_refptr<AudioInputController> controller =
132 AudioInputController::Create(audio_manager.get(), 131 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
133 &event_handler, 132 AudioManagerBase::kDefaultDeviceId, NULL);
134 params,
135 AudioManagerBase::kDefaultDeviceId,
136 NULL);
137 ASSERT_TRUE(controller.get()); 133 ASSERT_TRUE(controller.get());
138 134
139 // Start recording and trigger one OnRecording() call. 135 // Start recording and trigger one OnRecording() call.
140 controller->Record(); 136 controller->Record();
141 137
142 // Record and wait until ten OnData() callbacks are received. 138 // Record and wait until ten OnData() callbacks are received.
143 message_loop_.Run(); 139 message_loop_.Run();
144 140
145 // Close the AudioInputController synchronously. 141 // Close the AudioInputController synchronously.
146 CloseAudioController(controller.get()); 142 CloseAudioController(controller.get());
(...skipping 22 matching lines...) Expand all
169 .WillRepeatedly(CheckCountAndPostQuitTask( 165 .WillRepeatedly(CheckCountAndPostQuitTask(
170 &count, 10, message_loop_.task_runner())); 166 &count, 10, message_loop_.task_runner()));
171 167
172 // OnError() will be called after the data stream stops while the 168 // OnError() will be called after the data stream stops while the
173 // controller is in a recording state. 169 // controller is in a recording state.
174 EXPECT_CALL(event_handler, OnError(NotNull(), 170 EXPECT_CALL(event_handler, OnError(NotNull(),
175 AudioInputController::NO_DATA_ERROR)) 171 AudioInputController::NO_DATA_ERROR))
176 .Times(Exactly(1)) 172 .Times(Exactly(1))
177 .WillOnce(QuitMessageLoop(&message_loop_)); 173 .WillOnce(QuitMessageLoop(&message_loop_));
178 174
179 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
180 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout, 175 AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
181 kSampleRate, kBitsPerSample, kSamplesPerPacket); 176 kSampleRate, kBitsPerSample, kSamplesPerPacket);
182 177
183 // Creating the AudioInputController should render an OnCreated() call. 178 // Creating the AudioInputController should render an OnCreated() call.
184 scoped_refptr<AudioInputController> controller = 179 scoped_refptr<AudioInputController> controller =
185 AudioInputController::Create(audio_manager.get(), 180 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
186 &event_handler, 181 AudioManagerBase::kDefaultDeviceId, NULL);
187 params,
188 AudioManagerBase::kDefaultDeviceId,
189 NULL);
190 ASSERT_TRUE(controller.get()); 182 ASSERT_TRUE(controller.get());
191 183
192 // Start recording and trigger one OnRecording() call. 184 // Start recording and trigger one OnRecording() call.
193 controller->Record(); 185 controller->Record();
194 186
195 // Record and wait until ten OnData() callbacks are received. 187 // Record and wait until ten OnData() callbacks are received.
196 message_loop_.Run(); 188 message_loop_.Run();
197 189
198 // Stop the stream and verify that OnError() is posted. 190 // Stop the stream and verify that OnError() is posted.
199 AudioInputStream* stream = controller->stream_for_testing(); 191 AudioInputStream* stream = controller->stream_for_testing();
200 stream->Stop(); 192 stream->Stop();
201 message_loop_.Run(); 193 message_loop_.Run();
202 194
203 // Close the AudioInputController synchronously. 195 // Close the AudioInputController synchronously.
204 CloseAudioController(controller.get()); 196 CloseAudioController(controller.get());
205 } 197 }
206 198
207 // Test that AudioInputController rejects insanely large packet sizes. 199 // Test that AudioInputController rejects insanely large packet sizes.
208 TEST_F(AudioInputControllerTest, SamplesPerPacketTooLarge) { 200 TEST_F(AudioInputControllerTest, SamplesPerPacketTooLarge) {
209 // Create an audio device with a very large packet size. 201 // Create an audio device with a very large packet size.
210 MockAudioInputControllerEventHandler event_handler; 202 MockAudioInputControllerEventHandler event_handler;
211 203
212 // OnCreated() shall not be called in this test. 204 // OnCreated() shall not be called in this test.
213 EXPECT_CALL(event_handler, OnCreated(NotNull())) 205 EXPECT_CALL(event_handler, OnCreated(NotNull()))
214 .Times(Exactly(0)); 206 .Times(Exactly(0));
215 207
216 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
217 AudioParameters params(AudioParameters::AUDIO_FAKE, 208 AudioParameters params(AudioParameters::AUDIO_FAKE,
218 kChannelLayout, 209 kChannelLayout,
219 kSampleRate, 210 kSampleRate,
220 kBitsPerSample, 211 kBitsPerSample,
221 kSamplesPerPacket * 1000); 212 kSamplesPerPacket * 1000);
222 scoped_refptr<AudioInputController> controller = 213 scoped_refptr<AudioInputController> controller =
223 AudioInputController::Create(audio_manager.get(), 214 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
224 &event_handler, 215 AudioManagerBase::kDefaultDeviceId, NULL);
225 params,
226 AudioManagerBase::kDefaultDeviceId,
227 NULL);
228 ASSERT_FALSE(controller.get()); 216 ASSERT_FALSE(controller.get());
229 } 217 }
230 218
231 // Test calling AudioInputController::Close multiple times. 219 // Test calling AudioInputController::Close multiple times.
232 TEST_F(AudioInputControllerTest, CloseTwice) { 220 TEST_F(AudioInputControllerTest, CloseTwice) {
233 MockAudioInputControllerEventHandler event_handler; 221 MockAudioInputControllerEventHandler event_handler;
234 222
235 // OnRecording() will be called only once. 223 // OnRecording() will be called only once.
236 EXPECT_CALL(event_handler, OnCreated(NotNull())); 224 EXPECT_CALL(event_handler, OnCreated(NotNull()));
237 225
238 // OnRecording() will be called only once. 226 // OnRecording() will be called only once.
239 EXPECT_CALL(event_handler, OnRecording(NotNull())) 227 EXPECT_CALL(event_handler, OnRecording(NotNull()))
240 .Times(Exactly(1)); 228 .Times(Exactly(1));
241 229
242 scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
243 AudioParameters params(AudioParameters::AUDIO_FAKE, 230 AudioParameters params(AudioParameters::AUDIO_FAKE,
244 kChannelLayout, 231 kChannelLayout,
245 kSampleRate, 232 kSampleRate,
246 kBitsPerSample, 233 kBitsPerSample,
247 kSamplesPerPacket); 234 kSamplesPerPacket);
248 scoped_refptr<AudioInputController> controller = 235 scoped_refptr<AudioInputController> controller =
249 AudioInputController::Create(audio_manager.get(), 236 AudioInputController::Create(audio_manager_.get(), &event_handler, params,
250 &event_handler, 237 AudioManagerBase::kDefaultDeviceId, NULL);
251 params,
252 AudioManagerBase::kDefaultDeviceId,
253 NULL);
254 ASSERT_TRUE(controller.get()); 238 ASSERT_TRUE(controller.get());
255 239
256 controller->Record(); 240 controller->Record();
257 241
258 controller->Close(base::MessageLoop::QuitWhenIdleClosure()); 242 controller->Close(base::MessageLoop::QuitWhenIdleClosure());
259 base::MessageLoop::current()->Run(); 243 base::MessageLoop::current()->Run();
260 244
261 controller->Close(base::MessageLoop::QuitWhenIdleClosure()); 245 controller->Close(base::MessageLoop::QuitWhenIdleClosure());
262 base::MessageLoop::current()->Run(); 246 base::MessageLoop::current()->Run();
263 } 247 }
264 248
265 } // namespace media 249 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698