Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: media/audio/audio_manager_factory_unittest.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implemented ScopedAudioManagerPtr Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/message_loop/message_loop.h"
6 #include "media/audio/audio_manager.h" 7 #include "media/audio/audio_manager.h"
7 #include "media/audio/audio_manager_factory.h" 8 #include "media/audio/audio_manager_factory.h"
8 #include "media/audio/fake_audio_log_factory.h" 9 #include "media/audio/fake_audio_log_factory.h"
9 #include "media/audio/fake_audio_manager.h" 10 #include "media/audio/fake_audio_manager.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 namespace media { 13 namespace media {
13 namespace { 14 namespace {
14 15
15 class FakeAudioManagerFactory : public AudioManagerFactory { 16 class FakeAudioManagerFactory : public AudioManagerFactory {
16 public: 17 public:
17 FakeAudioManagerFactory() {} 18 FakeAudioManagerFactory() {}
18 ~FakeAudioManagerFactory() override {} 19 ~FakeAudioManagerFactory() override {}
19 20
20 AudioManager* CreateInstance(AudioLogFactory* audio_log_factory) override { 21 ScopedAudioManagerPtr CreateInstance(
22 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
23 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
24 AudioLogFactory* audio_log_factory) override {
25 ScopedAudioManagerPtr instance(new FakeAudioManager(
26 task_runner, worker_task_runner, audio_log_factory));
21 // |created_instance_| is used for verifying. Ownership is transferred to 27 // |created_instance_| is used for verifying. Ownership is transferred to
22 // caller. 28 // caller.
23 created_instance_ = new FakeAudioManager(audio_log_factory); 29 created_instance_ = instance.get();
24 return created_instance_; 30 return instance;
25 } 31 }
26 32
27 AudioManager* created_instance() { return created_instance_; } 33 AudioManager* created_instance() { return created_instance_; }
28 34
29 private: 35 private:
30 AudioManager* created_instance_; 36 AudioManager* created_instance_;
31 }; 37 };
32 38
33 } // namespace 39 } // namespace
34 40
35 // Verifies that SetFactory has the intended effect. 41 // Verifies that SetFactory has the intended effect.
36 TEST(AudioManagerFactoryTest, CreateInstance) { 42 TEST(AudioManagerFactoryTest, CreateInstance) {
43 FakeAudioLogFactory fake_audio_log_factory;
44 base::MessageLoop message_loop;
37 // Create an audio manager and verify that it is not null. 45 // Create an audio manager and verify that it is not null.
38 scoped_ptr<AudioManager> manager(AudioManager::CreateForTesting()); 46 ScopedAudioManagerPtr manager(AudioManager::Create(
47 message_loop.task_runner(), message_loop.task_runner(), nullptr,
48 &fake_audio_log_factory));
39 ASSERT_NE(nullptr, manager.get()); 49 ASSERT_NE(nullptr, manager.get());
40 manager.reset(); 50 manager.reset();
41 51
42 // Set the factory. Note that ownership of |factory| is transferred to 52 // Set the factory. Note that ownership of |factory| is transferred to
43 // AudioManager. 53 // AudioManager.
44 FakeAudioManagerFactory* factory = new FakeAudioManagerFactory(); 54 FakeAudioManagerFactory* factory = new FakeAudioManagerFactory();
45 AudioManager::SetFactory(factory); 55 AudioManager::SetFactory(factory);
46 56
47 // Create the AudioManager instance. Verify that it matches the instance 57 // Create the AudioManager instance. Verify that it matches the instance
48 // provided by the factory. 58 // provided by the factory.
49 manager.reset(AudioManager::CreateForTesting()); 59 manager = AudioManager::Create(message_loop.task_runner(),
60 message_loop.task_runner(), nullptr,
61 &fake_audio_log_factory);
50 ASSERT_NE(nullptr, manager.get()); 62 ASSERT_NE(nullptr, manager.get());
51 ASSERT_EQ(factory->created_instance(), manager.get()); 63 ASSERT_EQ(factory->created_instance(), manager.get());
52 64
53 // Reset AudioManagerFactory to prevent factory from persisting to other 65 // Reset AudioManagerFactory to prevent factory from persisting to other
54 // tests on the same process. |manager| will reset when scope exits. 66 // tests on the same process.
55 AudioManager::ResetFactoryForTesting(); 67 AudioManager::ResetFactoryForTesting();
56 } 68 }
57 69
58 } // namespace media 70 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698