Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1806313002: Add a flag to disable to New Tab Page toolbar (Closed)

Created:
4 years, 9 months ago by dgn
Modified:
4 years, 9 months ago
Reviewers:
May, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to disable to New Tab Page toolbar It is implemented using the base::Feature API. Use the command line flag `--disable-features=NTPToolbar` to disable it. BUG=595362 Committed: https://crrev.com/dd8b63c8a415bb8e4eaad0c7bfb4dd6ae5792ed8 Cr-Commit-Position: refs/heads/master@{#382004}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typos #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 2 3 chunks +34 lines, -22 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
dgn
PTAL
4 years, 9 months ago (2016-03-17 14:04:00 UTC) #2
May
lgtm https://codereview.chromium.org/1806313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/1806313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode122 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:122: /** @return Whether the toolbar at the bottom ...
4 years, 9 months ago (2016-03-17 14:27:00 UTC) #3
dgn
PTAL https://codereview.chromium.org/1806313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/1806313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode122 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:122: /** @return Whether the toolbar at the bottom ...
4 years, 9 months ago (2016-03-17 17:00:40 UTC) #5
newt (away)
https://codereview.chromium.org/1806313002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/1806313002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode334 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:334: toolbar.setVisibility(View.GONE); It'd be even better to remove the Toolbar ...
4 years, 9 months ago (2016-03-17 17:33:58 UTC) #7
dgn
PTAL https://codereview.chromium.org/1806313002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/1806313002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode334 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:334: toolbar.setVisibility(View.GONE); On 2016/03/17 17:33:58, newt wrote: > It'd ...
4 years, 9 months ago (2016-03-18 16:43:43 UTC) #8
newt (away)
lgtm :)
4 years, 9 months ago (2016-03-18 17:10:56 UTC) #9
dgn
Thanks!
4 years, 9 months ago (2016-03-18 17:12:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806313002/40001
4 years, 9 months ago (2016-03-18 17:12:30 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 17:27:58 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/dd8b63c8a415bb8e4eaad0c7bfb4dd6ae5792ed8 Cr-Commit-Position: refs/heads/master@{#382004}
4 years, 9 months ago (2016-03-18 17:30:11 UTC) #17
dgn
4 years, 4 months ago (2016-08-22 17:11:16 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2269703002/ by dgn@chromium.org.

The reason for reverting is: Terminating the experiment.

Powered by Google App Engine
This is Rietveld 408576698