Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: content/renderer/media/user_media_client_impl.cc

Issue 1806303002: Copy device IDs from advanced constraints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/user_media_client_impl.cc
diff --git a/content/renderer/media/user_media_client_impl.cc b/content/renderer/media/user_media_client_impl.cc
index 12a9529746ccd543341416119017065b14640fa1..6164b9665800b4e1e0448fa404fec84a550c8e10 100644
--- a/content/renderer/media/user_media_client_impl.cc
+++ b/content/renderer/media/user_media_client_impl.cc
@@ -64,13 +64,17 @@ void CopyBlinkRequestToStreamControls(const blink::WebUserMediaRequest& request,
const blink::WebMediaTrackConstraintSet& audio_basic =
request.audioConstraints().basic();
CopyFirstString(audio_basic.mediaStreamSource.exact(),
- &(controls->audio.stream_source));
+ &controls->audio.stream_source);
CopyVector(audio_basic.deviceId.exact(), &(controls->audio.device_ids));
// Optionals. They may be either in ideal or in advanced.exact.
- // TODO(hta): Get alternatives only mentioned in advanced array.
CopyVector(audio_basic.deviceId.ideal(),
&controls->audio.alternate_device_ids);
-
+ for (const auto& constraint : request.audioConstraints().advanced()) {
+ CopyVector(constraint.deviceId.exact(),
+ &controls->audio.alternate_device_ids);
+ CopyVector(constraint.deviceId.ideal(),
+ &controls->audio.alternate_device_ids);
+ }
if (audio_basic.hotwordEnabled.hasExact()) {
controls->hotword_enabled = audio_basic.hotwordEnabled.exact();
} else {
@@ -90,6 +94,12 @@ void CopyBlinkRequestToStreamControls(const blink::WebUserMediaRequest& request,
CopyVector(video_basic.deviceId.exact(), &(controls->video.device_ids));
CopyVector(video_basic.deviceId.ideal(),
&(controls->video.alternate_device_ids));
+ for (const auto& constraint : request.videoConstraints().advanced()) {
+ CopyVector(constraint.deviceId.exact(),
+ &controls->video.alternate_device_ids);
+ CopyVector(constraint.deviceId.ideal(),
+ &controls->video.alternate_device_ids);
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698