ppapi/shared_impl/tracked_callback.h - Issue 18063005: Do PPB_FileIO Query and Read in the plugin process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/tracked_callback.h

Issue 18063005: Do PPB_FileIO Query and Read in the plugin process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rethink - Just optimize the blocking callback case. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/tracked_callback.h

diff --git a/ppapi/shared_impl/tracked_callback.h b/ppapi/shared_impl/tracked_callback.h

index 4917990e3cfeafa31ebb70623bc4538c1685b3a9..5424eeb38bb5cf383576c1a81d4e957736e6f0d5 100644

--- a/ppapi/shared_impl/tracked_callback.h

+++ b/ppapi/shared_impl/tracked_callback.h

@@ -112,11 +112,12 @@ class PPAPI_SHARED_EXPORT TrackedCallback

// message loop.

static bool IsScheduledToRun(const scoped_refptr<TrackedCallback>& callback);

- protected:

+ // Returns true if this is a blocking callback.

bool is_blocking() {

return !callback_.func;

}

+ protected:

bool is_required() {

return (callback_.func &&

!(callback_.flags & PP_COMPLETIONCALLBACK_FLAG_OPTIONAL));