chrome/browser/extensions/api/time/time_api.h - Issue 18063003: Chromium extension API - written as part of course in Open Software Development at Reykjavik Univer…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/time/time_api.h

Issue 18063003: Chromium extension API - written as part of course in Open Software Development at Reykjavik Univer… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixing lint errors. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
	Jói 2013/06/28 10:49:15 2013 2013 hpjonsson 2013/06/28 12:13:04 Done. Show quoted text On 2013/06/28 10:49:15, Jói wrote: > 2013 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef CHROME_BROWSER_EXTENSIONS_API_TIME_TIME_API_H_

	5 #define CHROME_BROWSER_EXTENSIONS_API_TIME_TIME_API_H_

	6

	7 #include "chrome/common/extensions/api/time.h"

	8 #include "chrome/browser/extensions/extension_function.h"

	9
	Jói 2013/06/28 10:49:15 One blank line is enough. One blank line is enough. hpjonsson 2013/06/28 12:13:04 Done. Show quoted text On 2013/06/28 10:49:15, Jói wrote: > One blank line is enough. Done.
	10

	11 namespace extensions {
	Jói 2013/06/28 10:49:15 Usually we put a blank line after this. Usually we put a blank line after this. hpjonsson 2013/06/28 12:13:04 Done. Show quoted text On 2013/06/28 10:49:15, Jói wrote: > Usually we put a blank line after this. Done.
	12 class TimeGetTimeFunction : public AsyncExtensionFunction {

	13 private:
	Jói 2013/06/28 10:49:15 indent -1 indent -1
	14 virtual ~TimeGetTimeFunction();
	Jói 2013/06/28 10:49:15 Not sure, but the destructor probably needs to be Not sure, but the destructor probably needs to be public. If it compiles like this, fine. einartryggvi 2013/06/28 10:57:49 We got an error saying a virtual destructor has to We got an error saying a virtual destructor has to be private, thought it was weird though. On 2013/06/28 10:49:15, Jói wrote: Show quoted text > Not sure, but the destructor probably needs to be public. If it compiles like > this, fine.
	15 DECLARE_EXTENSION_FUNCTION("time.getTime", TIME_GETTIME);

	16 virtual bool RunImpl() OVERRIDE;

	17 };
	Jói 2013/06/28 10:49:15 indent -2 indent -2 hpjonsson 2013/06/28 12:13:04 Done. Show quoted text On 2013/06/28 10:49:15, Jói wrote: > indent -2 Done.
	18 } // namespace extensions

	19

	20 #endif // CHROME_BROWSER_EXTENSIONS_API_TIME_TIME_API_H_

	21

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/extensions/api/time/time_api.cc » ('j') | chrome/browser/extensions/api/time/time_api.cc » ('J')