Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1806263005: Do not crash when measuring empty SVG text nodes (Closed)

Created:
4 years, 9 months ago by pdr.
Modified:
4 years, 9 months ago
Reviewers:
chrishtr, fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not crash when measuring empty SVG text nodes A regression was introduced by [1] where the loop in SVGTextMetricsBuilder::measureTextLayoutObject would no longer check if there was any text before attempting to measure the text. This patch adds the trivial empty text check and adds a new test for this edgecase. [1] https://chromium.googlesource.com/chromium/src/+/304ec1544273ed8d62c693da6dd2c63727805cdd BUG=596148, 589525 Committed: https://crrev.com/8e375826a04e52a50c4656f64eaa29c7fb05927c Cr-Commit-Position: refs/heads/master@{#382170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/text/empty-text-node-crash.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pdr.
4 years, 9 months ago (2016-03-19 00:05:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806263005/1
4 years, 9 months ago (2016-03-19 00:05:54 UTC) #4
chrishtr
lgtm
4 years, 9 months ago (2016-03-19 00:12:00 UTC) #5
fs
lgtm
4 years, 9 months ago (2016-03-19 00:13:33 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-19 02:23:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806263005/1
4 years, 9 months ago (2016-03-19 02:24:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 02:30:01 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 02:31:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e375826a04e52a50c4656f64eaa29c7fb05927c
Cr-Commit-Position: refs/heads/master@{#382170}

Powered by Google App Engine
This is Rietveld 408576698